Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prefix to chunk cache flags #2191

Closed
tomwilkie opened this issue Feb 27, 2020 · 0 comments · Fixed by #2241
Closed

Add a prefix to chunk cache flags #2191

tomwilkie opened this issue Feb 27, 2020 · 0 comments · Fixed by #2241
Assignees
@gouthamve
Milestone
v1

Comments

@tomwilkie
Copy link
Contributor

Its the only one without a prefix, and thats confusing.
@tomwilkie tomwilkie added this to the v1 milestone Feb 27, 2020
@gouthamve gouthamve mentioned this issue Mar 10, 2020
Merged
2 tasks
gouthamve added a commit to gouthamve/cortex that referenced this issue Mar 24, 2020
@gouthamve
Prefix chunks cache flags.
7488756 
Fixes cortexproject#2191

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit that referenced this issue Mar 24, 2020
@gouthamve
Prefix chunks cache flags. (#2241)
9bf77e7 
* Prefix chunks cache flags.

Fixes #2191

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Move background cache prefix to cache from memcache

Fixes #553

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Update docs for the cache flag changes.

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Fix all docs references

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Rebase and update prefixes in doc

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Review feedback

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Address feedback

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@gouthamve
Prefix chunks cache flags. (grafana#2241)
72132b6 
* Prefix chunks cache flags.

Fixes cortexproject/cortex#2191

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Move background cache prefix to cache from memcache

Fixes grafana#553

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Update docs for the cache flag changes.

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Fix all docs references

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Rebase and update prefixes in doc

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Review feedback

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Address feedback

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gouthamve gouthamve

Labels
None yet
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Prefix chunks cache flags. gouthamve/cortex
2 participants
@tomwilkie @gouthamve