treefile: Add exclude-packages #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally but still WIP to add a test that a compose fails with this. And also needs docs - before I write those let's bikeshed on naming etc. |
2f1696d to
d367901
Compare
d367901 to
44b4ee8
Compare
|
I remember talking about this with @jlebon. Looking a bit around, I found these prior discussions:
If you are looking for feedback on naming, I'd personally go for something which is aligned with the underlying libdnf feature (i.e. containing |
jlebon
reviewed
Feb 5, 2020
44b4ee8 to
7673390
Compare
|
/lgtm |
In FCOS we have a kola test that basically does `rpm -q python`. It's...a bit silly to spawn a whole VM for this. Ensuring that some specific packages don't get included has come up in a few cases. I think FCOS/RHCOS at least will want to blacklist `dnf` for example. And as noted above, FCOS could blacklist `python`. One major benefit of doing this inside rpm-ostree is that one gets the full "libsolv error message experience" when dependency resolution fails, e.g. blacklisting `glibc` I get: ``` Problem 79: conflicting requests - package coreos-installer-systemd-0.1.2-1.fc31.x86_64 requires coreos-installer = 0.1.2-1.fc31, but none of the providers can be installed - package coreos-installer-0.1.2-1.fc31.x86_64 requires rtld(GNU_HASH), but none of the providers can be installed - package glibc-2.30-10.fc31.x86_64 is filtered out by exclude filtering - package glibc-2.30-7.fc31.x86_64 is filtered out by exclude filtering - package glibc-2.30-8.fc31.x86_64 is filtered out by exclude filtering - package glibc-2.30-5.fc31.i686 is filtered out by exclude filtering - package glibc-2.30-5.fc31.x86_64 is filtered out by exclude filtering - package glibc-2.30-10.fc31.i686 is filtered out by exclude filtering ```
7673390 to
583a265
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Feb 7, 2020
This makes use of the new coreos/rpm-ostree#1980 And we can then drop the test in kola that boots a whole VM for this.
jlebon
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 10, 2020
This makes use of the new coreos/rpm-ostree#1980 And we can then drop the test in kola that boots a whole VM for this.
This was referenced Feb 10, 2020
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Feb 11, 2020
We want to pull in the v2020.1 version of `rpm-ostree` for the `exclude-packages` support[0]. @jlebon was nice enough to rebuild `rpm-ostree` with that support in F30, so blow out the cache to make sure we pick it up. [0] coreos/rpm-ostree#1980
miabbott
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Feb 20, 2020
We want to pull in the v2020.1 version of `rpm-ostree` for the `exclude-packages` support[0]. @jlebon was nice enough to rebuild `rpm-ostree` with that support in F30, so blow out the cache to make sure we pick it up. [0] coreos/rpm-ostree#1980 (cherry picked from commit 1f0f61e)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FCOS we have a kola test that basically does
rpm -q python.It's...a bit silly to spawn a whole VM for this. Ensuring that
some specific packages don't get included has come up in a few
cases.
I think FCOS/RHCOS at least will want to blacklist
dnffor example.And as noted above, FCOS could blacklist
python.One major benefit of doing this inside rpm-ostree is that one
gets the full "libsolv error message experience" when dependency
resolution fails, e.g. blacklisting
glibcI get: