Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Dockerfile: blow out quay.io cache #1124

Merged
merged 1 commit into from
Feb 11, 2020
Merged

[4.2] Dockerfile: blow out quay.io cache #1124

merged 1 commit into from
Feb 11, 2020

Conversation

miabbott
Copy link
Member

We want to pull in the v2020.1 version of rpm-ostree for the
exclude-packages support[0]. @jlebon was nice enough to rebuild
rpm-ostree with that support in F30, so blow out the cache to make
sure we pick it up.

[0] coreos/rpm-ostree#1980

We want to pull in the v2020.1 version of `rpm-ostree` for the
`exclude-packages` support[0].  @jlebon was nice enough to rebuild
`rpm-ostree` with that support in F30, so blow out the cache to make
sure we pick it up.

[0] coreos/rpm-ostree#1980
@miabbott
Copy link
Member Author

Successful RHCOS build using exclude-packages here - https://url.corp.redhat.com/219302d

@jlebon
Copy link
Member

jlebon commented Feb 11, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon, miabbott
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miabbott
Copy link
Member Author

Weird, we have lgtm_acts_as_approve set for this repo - https://github.com/openshift/release/blob/master/core-services/prow/02_config/_plugins.yaml#L83-L86

@jlebon
Copy link
Member

jlebon commented Feb 11, 2020

Ahh, there is no OWNERS on this branch, and there is also no .cci.jenkinsfile either. Though not sure how useful it'd be if it's building git master FCOS instead of RHCOS anyway. Let's just manually merge it since it's not actually doing any code changes anyway (and at least Travis CI is green).

@jlebon jlebon merged commit 0c51834 into coreos:rhcos-4.2 Feb 11, 2020
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
Do not mount root parition for injecting ignition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants