-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Changes to support F31 in Dockerfile #1121
Conversation
So we have one fewer random place to change when bumping Fedora versions. Prep for rebasing on F31. (cherry picked from commit bee3ec5)
(cherry picked from commit ad6c9e4)
For RHCOS builds, we want the ability to use `exclude-packages`[0] from `rpm-ostree`. The easiest way to get this it to start using F31 in the Dockerfile. [0] coreos/rpm-ostree#1980
I was able to successfully build RHCOS with this image and a modified manifest to use |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miabbott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hmm.. I thinking for 4.2 we'd want to minimize any changes. I take it what you need is a newer version of |
You know I just blindly went for the whole hog replacement, but I should give that conservative approach a shot. |
That probably won't work without also bringing in f31's e.g. librpm, glibc, etc... too. But I can easily rebuild 2020.1 too into the f30 continuous tag. :) |
I'll give it a try in parallel to the F30 rebuild, if you would be so kind. :) |
It's in the continuous tag now, so a rebuild should pick it up: https://koji.fedoraproject.org/koji/buildinfo?buildID=1458708 |
The rebuilt F30 worked flawlessly (obviously!). Rather than re-use this PR, I'll open a new one with the change needed. |
build-sys: Add `make install`
In the RHCOS world, a change to the spec file of
skopeo
causedsubscription-manager
,dnf
, and all the associated dependencies to be dragged into the OS. [0]While we investigate the impact of disabling
Recommends
for RHCOS builds, the workaround is to use theexclude-packages
support[1] that was recently landed inrpm-ostree
. The most direct way to do this is to rebase the Dockerfile forcoreos-assembler
on F31.[0] https://bugzilla.redhat.com/show_bug.cgi?id=1798278
[1] coreos/rpm-ostree#1980