Compat api containers ImageId missing sha256 #12705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash your commits and add a test. git rebase -i origin |
|
Remove the draft status. This is looking good. |
flouthoc
reviewed
Dec 28, 2021
flouthoc
reviewed
Dec 28, 2021
flouthoc
approved these changes
Dec 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, olitha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test for compat API ImageId Signed-off-by: Oliver Thallmair <oliver.thallmair@mailbox.org>
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
Description
The Docker API /containers/json return the ImageId with a
sha256:prefix. Podman compat API does not. Similar to #11656Steps to reproduce the issue:
curl -X GET --unix-socket /var/run/docker.sock "v1.40/containers/jsonreturnspodman compat API returns
Describe the results you received:
see above
Describe the results you expected:
podman prefixes ImageId with sha256:
Additional information you deem important (e.g. issue happens only occasionally):
Output of
podman version:Version: 3.4.2
API Version: 3.4.2
Go Version: go1.16.6
Built: Thu Jan 1 01:00:00 1970
OS/Arch: linux/amd64
Output of
podman info --debug:Package info (e.g. output of
rpm -q podmanorapt list podman):Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)
Tested with main branch
Yes
Additional environment details (AWS, VirtualBox, physical, etc.):