Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat API: /images/json prefix image id with sha256 #11656

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 20, 2021

Docker adds the sha256: prefix to the image ID, so our compat endpoint
has to do this as well.

Fixes #11623

Docker adds the `sha256:` prefix to the image ID, so our compat endpoint
has to do this as well.

Fixes containers#11623

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2021

LGTM
@jwhonce @mheon @baude PTAL

@mheon
Copy link
Member

mheon commented Sep 20, 2021

LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2021

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You may need to rebase to fix the F33 flake.

@jwhonce
Copy link
Member

jwhonce commented Sep 20, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4cdffd0 into containers:main Sep 20, 2021
@Luap99 Luap99 deleted the compat-id branch September 20, 2021 16:35
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker API image queries returning differing Id values
6 participants