Merge pull request #12705 from olitha/compat-api-containers-sha256

Compat api containers ImageId missing sha256
containers · Dec 29, 2021 · 807f7cf · 807f7cf
2 parents e06631d + a268778
commit 807f7cf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/api/handlers/compat/containers.go b/pkg/api/handlers/compat/containers.go
@@ -360,7 +360,7 @@ func LibpodToContainer(l *libpod.Container, sz bool) (*handlers.Container, error
 		ID:         l.ID(),
 		Names:      []string{fmt.Sprintf("/%s", l.Name())},
 		Image:      imageName,
-		ImageID:    imageID,
+		ImageID:    "sha256:" + imageID,
 		Command:    strings.Join(l.Command(), " "),
 		Created:    l.CreatedTime().Unix(),
 		Ports:      ports,

diff --git a/test/apiv2/20-containers.at b/test/apiv2/20-containers.at
@@ -46,6 +46,10 @@ t GET /containers/json?all=true 200 \
   .[0].Image=$IMAGE \
   $network_expect
 
+# compat API imageid with sha256: prefix
+t GET containers/json?limit=1 200 \
+  .[0].ImageID~sha256:[0-9a-f]\\{64\\}
+
 # Make sure `limit` works.
 t GET libpod/containers/json?limit=1 200 \
   length=1 \