Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to torchaudio 2.5.1 and rebuild with pytorch 2.5.1 #12

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Dec 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #8
Closes #10

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 5, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12224491957. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jeongseok-meta jeongseok-meta changed the title torchaudio 2.5.1 Update to torchaudio 2.5.1 and rebuild with pytorch 2.5.1 Dec 5, 2024
recipe/build.sh Outdated Show resolved Hide resolved
@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12173792070. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12224401354. Examine the logs at this URL for more detail.

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@jeongseok-meta
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jeongseok-meta jeongseok-meta marked this pull request as ready for review December 8, 2024 19:56
@jeongseok-meta
Copy link
Contributor Author

jeongseok-meta commented Dec 8, 2024

@h-vetinari It turned out that the latest pytorch build was broken. Now that it's fixed, this PR simply updates the pytorch and the torchaudio versions to the latest.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the fix in the right place.

@h-vetinari h-vetinari merged commit d6d4767 into conda-forge:main Dec 8, 2024
30 of 31 checks passed
@jeongseok-meta jeongseok-meta deleted the 2.5.1 branch December 9, 2024 01:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the name is off here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for that. Thanks for fixing it in #15!

@h-vetinari h-vetinari mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants