Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #8

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #7.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #7

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Dec 5, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12170699425. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review December 5, 2024 00:16
@jeongseok-meta
Copy link
Contributor

It appears that the linter is failing because the recipe file is named recipe.yaml instead of meta.yaml. Additionally, recipe.yaml contains a context: section, which does not seem to be valid syntax for meta.yaml. Is this intentional? Should we consider renaming it to meta.yaml and adjusting or removing the context section accordingly?

@jeongseok-meta
Copy link
Contributor

Hmm, rerendering doesn't update the pytorch version (it still points to 2.4). Does anyone have an idea how to enforce this package to build with pytorch? I believe there are no actual blockers, just the migrator's error, which I'm not sure if it's fixed or actually broken though..

@jeongseok-meta
Copy link
Contributor

It appears that the linter is failing because the recipe file is named recipe.yaml instead of meta.yaml. Additionally, recipe.yaml contains a context: section, which does not seem to be valid syntax for meta.yaml. Is this intentional? Should we consider renaming it to meta.yaml and adjusting or removing the context section accordingly?

Ah, it's in recipe format for rattler-build: https://prefix-dev.github.io/rattler-build/latest/recipe_generation/
I'm still unsure if it's acceptable to ignore linter warnings or whether the linter and other conda-forge bots will work with this format though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
2 participants