Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerender #15

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Rerender #15

wants to merge 4 commits into from

Conversation

h-vetinari
Copy link
Member

Due to changes in rattler, the recipe is currently not rerenderable anymore. Also the migrator file was named wrongly in #12. Fix both, so that the bot can handle this feedstock again.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jan 24, 2025
@h-vetinari h-vetinari added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Jan 24, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 24, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ The use of xz is deprecated. If your package links to liblzma, use the new liblzma-devel package. For XZ's command line utilities (like xz and unxz), use the xz-toolspackage. For the xz-enabled GNU tools (like grep), use xz-gpl-tools. Note: Command line utilities should go in requirements/build.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12944780379. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Jan 24, 2025
@h-vetinari
Copy link
Member Author

OK, this is now segfaulting consistently for CUDA 12.6 in what appears to be the kaldi integration tests

 │ test/torchaudio_unittest/functional/kaldi_compatibility_cpu_test.py::TestKaldiFloat32::test_sliding_window_cmn PASSED [ 65%]
 │ test/torchaudio_unittest/functional/kaldi_compatibility_cpu_test.py::TestKaldiFloat64::test_sliding_window_cmn PASSED [ 65%]
 │ test/torchaudio_unittest/functional/kaldi_compatibility_cuda_test.py::TestKaldiFloat32::test_sliding_window_cmn SKIPPED [ 65%]
 │ test/torchaudio_unittest/functional/kaldi_compatibility_cuda_test.py::TestKaldiFloat64::test_sliding_window_cmn SKIPPED [ 65%]
 │ Fatal Python error: Segmentation fault
 │ Current thread 0x00007f291a033400 (most recent call first):

I suspect that we should rebuild kaldi for 12.6 but this has failed: conda-forge/kaldi-feedstock#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants