Fixes #14166: Add strip option to cmake.install tool

[sagi-ottopia]

Changelog: Feature: Add new tools.cmake:install_strip conf to add --strip option to cmake install.
Docs: conan-io/docs#3281

Fix: #14166

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

[CLAassistant]

All committers have signed the CLA.

[memsharded]

Thanks for your contribution.

as the CMake is a wrapper around the command line I see no strong reason against this feature and this PR. However, this approach requires modifying recipes, maybe it would make sense to have a conf like tools.cmake.install:strip=xxx that controls that behavior, so it is possible to do it at scale for the whole dependency graph?

For this PR, it would be great if you could add some unit test that covers the behavior. I think that a unittest could be enough for this one, please have a look, and if you need help, let us know, we can contribute the test. Thanks again!

[sagi-ottopia]

Hi,
Regarding a conf value, I think it should be easy to add it to the PR as well. I will look for some example and will update the PR accordingly.

Regarding unittests, sure.

[memsharded]

Regarding a conf value, I think it should be easy to add it to the PR as well. I will look for some example and will update the PR accordingly.

Only if it makes sense as a use case, is it something that you will prefer over modifying the recipes? Is it something that makes sense to do for all packages in the graph or is it something specific to some?

I am adding @jcar87 for some feedback about this use case too.

[sagi-ottopia]

Regarding a conf value, I think it should be easy to add it to the PR as well. I will look for some example and will update the PR accordingly.

Only if it makes sense as a use case, is it something that you will prefer over modifying the recipes? Is it something that makes sense to do for all packages in the graph or is it something specific to some?

I am adding @jcar87 for some feedback about this use case too.

I think it makes sense,
because when using the a conf value I can add it just in my Release builds profile without the need to have something like the following in my conanfile.py:

do_strip = False
if self.settings.build_type == 'Release':
   do_strip = True
...
cmake.install(strip=do_strip)

[memsharded]

if self.settings.build_type == 'Release':

Ok, makes sense, though nowadays, I'd expect that Release builds already don't contain any debug information to be stripped, I understand it might not be the case for all platforms and tools, so I am ok with making this a opt-in conf.

[memsharded]

Looks great, many thanks!

[sagi-ottopia]

Hi @memsharded,
saw that you added this into 2.0.8 timeline,
is it possible to merge it also to 1.XX latest version ?
Thanks.

[memsharded]

Yes, sorry, didn't check the target branch. Moved it to 1.61, and then I will merge it myself to 2.0 branch (2.0.8 will probably be out earlier than 1.61)

[jcar87]

if self.settings.build_type == 'Release':

Ok, makes sense, though nowadays, I'd expect that Release builds already don't contain any debug information to be stripped, I understand it might not be the case for all platforms and tools, so I am ok with making this a opt-in conf.

From https://discourse.cmake.org/t/what-does-strip-do/4302 and if I'm not mistaken, it's not only debug information that gets stripped (if there is any), but also symbols that don't need to be externally visible, so this should have a benefit.

PR looks good to me, thanks @sagi-ottopia for your contribution!!!

@memsharded one thing I'd consider outside of this PR is adding a cli_args argument to cmake.install() - to mirror what we have for cmake.configure() and cmake.build() - while the current setup for install pretty much covers the bases, it may be useful for some advanced users to have the added flexibility