Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add '--strip' option to cmake install #14166

Closed
1 task done
sagi-ottopia opened this issue Jun 25, 2023 · 1 comment · Fixed by #14167
Closed
1 task done

[feature] Add '--strip' option to cmake install #14166

sagi-ottopia opened this issue Jun 25, 2023 · 1 comment · Fixed by #14167
Milestone
1.61

Comments

@sagi-ottopia
Copy link
Contributor

What is your suggestion?

Can you add a parameter to cmake.install function in order to be able to strip binaries before install ?

install and strip were added to CMake about 4 years ago, and if I got it correctly in version 3.15
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3069

Strip is very useful to remove debug symbols (actually all DWARF extension) from binaries and especially release binaries.

I tried many options to make it work with conan, but without success, so I think adding this option as a parameter to install function in cmake tool will be the best solution instead of some workarounds.

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@sagi-ottopia sagi-ottopia mentioned this issue Jun 25, 2023
Merged
5 tasks
memsharded added a commit that referenced this issue Jul 6, 2023
@sagi-ottopia @memsharded
Fixes #14166: Add strip option to cmake.install tool (#14167)
0966e79 
* Add strip option to cmake.install tool

* Use conf option to enable cmake strip

* update conf to be install_strip

Co-authored-by: James <memsharded@gmail.com>

* update conf to be install_strip

Co-authored-by: James <memsharded@gmail.com>

---------

Co-authored-by: James <memsharded@gmail.com>
@memsharded memsharded added this to the 1.61 milestone Jul 6, 2023
@memsharded
Copy link
Member

Closed by #14167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.61
Development

Successfully merging a pull request may close this issue.

Fixes #14166: Add strip option to cmake.install tool sagi-ottopia/conan
2 participants
@memsharded @sagi-ottopia