Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14166: Add strip docs to cmake.install #3281

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

sagi-ottopia
Copy link

@sagi-ottopia sagi-ottopia commented Jun 25, 2023

Fixes #14166: Add strip docs to cmake.install

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated now to conan-io/conan#14167

Thanks for contributing the docs too!

@sagi-ottopia
Copy link
Author

Hi, I would like to update the docs according to the change that I made.
Where do you think is the most appropriate docs/section for it ?
Sagi

@memsharded
Copy link
Member

https://docs.conan.io/1/reference/conanfile/tools/cmake/cmake.html#install would be good.

I have just merged develop -> release/2.0, so this will be in next 2.0.8 too

@sagi-ottopia sagi-ottopia requested a review from memsharded July 9, 2023 12:27
@memsharded memsharded merged commit b8cdc44 into conan-io:develop Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants