-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- [cairo] switch to meson #7842
Conversation
This comment has been minimized.
This comment has been minimized.
okay, it seems like only 1.17.4 contains meson.build, let's change the structure a bit |
Signed-off-by: SSE4 <tomskside@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small detail. Goo job.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
All green in build 8 (
|
Seems to be a big cons compared to pros. What is the advantage for consumers (not maintainers)? |
yes, it's pretty significant disadvantage for consumers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have objections.
I also worked on porting cairo to use meson: https://github.com/sh0/conan-center-index/tree/cairo-meson-fix/recipes/cairo/meson My conanfile has also support for OpenGL (desktop, gles2, gles3). IMHO without meson the MSVC build is a hot mess and it is probably not possible to get OpenGL working there. So it is a tradeoff between autotools/msbuild and meson. |
* - [cairo] switch to meson Signed-off-by: SSE4 <tomskside@gmail.com> * Update recipes/cairo/meson/conanfile.py * Update recipes/cairo/meson/test_package/CMakeLists.txt Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/cairo/meson/test_package/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
* - [cairo] switch to meson Signed-off-by: SSE4 <tomskside@gmail.com> * Update recipes/cairo/meson/conanfile.py * Update recipes/cairo/meson/test_package/CMakeLists.txt Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/cairo/meson/test_package/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Specify library name and version: cairo/all
closes: #7732
to unblock: #7691
switch
cairo
builds to meson, as commented out in https://gitlab.freedesktop.org/cairo/cairo/-/issues/75:pros:
meson
) instead ofautotools
+msbuild
cairo-gobject
and all other targets are properly supportedcons:
also added some previously missing options, requirements and components
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.