Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- [gst-plugins-good] 1.19.1 #7691

Merged
merged 9 commits into from
Feb 7, 2022
Merged

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Oct 15, 2021

Specify library name and version: gst-plugins-good/1.19.1

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot

This comment has been minimized.

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor Author

SSE4 commented Oct 17, 2021

seems like cairo-gobject.dll is missing:
image

@stale
Copy link

stale bot commented Nov 16, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 16, 2021
@SSE4 SSE4 closed this Dec 1, 2021
@SSE4 SSE4 reopened this Dec 1, 2021
@stale stale bot removed the stale label Dec 1, 2021
@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 mentioned this pull request Dec 1, 2021
4 tasks
@stale
Copy link

stale bot commented Dec 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2021
@daravi
Copy link
Contributor

daravi commented Jan 9, 2022

@SSE4 Hi just wondering if this fell of the radar by accident or if it is blocked by something else?

@stale stale bot removed the stale label Jan 9, 2022
@SSE4
Copy link
Contributor Author

SSE4 commented Jan 9, 2022

@SSE4 Hi just wondering if this fell of the radar by accident or if it is blocked by something else?

yes, it's definitely on my Radar. I had long x-mas holidays, but I hope tomorrow I'll take an another look.

@SSE4
Copy link
Contributor Author

SSE4 commented Jan 10, 2022

@SSE4 Hi just wondering if this fell of the radar by accident or if it is blocked by something else?

for the record, PRs to follow up: #8378 and #8800

@SSE4 SSE4 mentioned this pull request Jan 16, 2022
4 tasks
@SSE4 SSE4 closed this Jan 21, 2022
@conan-center-bot

This comment has been minimized.

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@SSE4
Copy link
Contributor Author

SSE4 commented Jan 21, 2022

weird, I cannot reproduce failure locally with the same profile 🤔 perhaps, I'll try adding some additional logging. @daravi or maybe you can take a look if you have a time.

P.S. one more thing to be fixed, I'll open a PR:

WARN: pango/1.49.1: requirement glib/2.70.1 overridden by gst-plugins-base/1.19.1 to glib/2.70.0 
WARN: cairo/1.17.4: requirement glib/2.70.1 overridden by pango/1.49.1 to glib/2.70.0 
WARN: harfbuzz/3.2.0: requirement glib/2.70.1 overridden by pango/1.49.1 to glib/2.70.0 

@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 mentioned this pull request Jan 21, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 force-pushed the gst-plugins-good branch from 8eaec0d to 3104e7d Compare January 21, 2022 14:34
@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor Author

SSE4 commented Jan 21, 2022

don't see much useful info...

23118:23f10 @ 818593484 - LdrpFindDllActivationContext - INFO: Probing for the manifest of DLL "C:\J\w\BuildSingleReference@2\.conan\data\gst-plugins-good\1.19.1\_\_\package\3bf60f0613e70e2876c6a5db6e066327b5b39e9c\lib\gstreamer-1.0\gstwavparse.dll" failed with status 0xc0000089
...
23118:23f10 @ 818593484 - LdrpInitializeNode - INFO: Calling init routine 00007FF941908CE4 for DLL "C:\J\w\BuildSingleReference@2\.conan\data\gst-plugins-good\1.19.1\_\_\package\3bf60f0613e70e2876c6a5db6e066327b5b39e9c\lib\gstreamer-1.0\gstwavparse.dll"
...
23118:23f10 @ 818593484 - LdrpInitializeNode - ERROR: Init routine 00007FF941908CE4 for DLL "C:\J\w\BuildSingleReference@2\.conan\data\gst-plugins-good\1.19.1\_\_\package\3bf60f0613e70e2876c6a5db6e066327b5b39e9c\lib\gstreamer-1.0\gstwavparse.dll" failed during DLL_PROCESS_ATTACH
23118:23f10 @ 818593484 - LdrpProcessDetachNode - INFO: Uninitializing DLL "C:\J\w\BuildSingleReference@2\.conan\data\gst-plugins-good\1.19.1\_\_\package\3bf60f0613e70e2876c6a5db6e066327b5b39e9c\lib\gstreamer-1.0\gstwavparse.dll" (Init routine: 00007FF941908CE4)
23118:23f10 @ 818593484 - LdrpUnloadNode - INFO: Unmapping DLL "C:\J\w\BuildSingleReference@2\.conan\data\gst-plugins-good\1.19.1\_\_\package\3bf60f0613e70e2876c6a5db6e066327b5b39e9c\lib\gstreamer-1.0\gstwavparse.dll"
23118:23f10 @ 818593484 - LdrpLoadDllInternal - RETURN: Status: 0xc0000142
23118:23f10 @ 818593484 - LdrLoadDll - RETURN: Status: 0xc0000142

0xc0000089 is STATUS_RESOURCE_DATA_NOT_FOUND
0xc0000142 is STATUS_DLL_INIT_FAILED

maybe something with manifest? UPD: it doesn't have a manifest, and it should be fine

@SSE4
Copy link
Contributor Author

SSE4 commented Jan 21, 2022

as it happens only with MT builds, this explanation appears to be logical:

FlsAlloc returned FLS_OUT_OF_INDEXES, which in turned failed the CRT initialization.
A little research shows that Fiber Local Storage has 128 slots per process;
each DLL statically linked to CRT will take a slot during CRT initialization.
There is possibility that if process has loaded too many DLLs and exhausted FLS slots,
then new DLL statically linked to CRT will fail to load, and that is exactly what we ran into.

as GStreamer for sure has lots of DLLs, and we could have easily loaded 128 DLLs linked with static runtime.
I am not sure, is it worth to provide this configuration at all in this case (shared + static CRT?)
some reading:
https://stevedower.id.au/blog/building-for-python-3-5-part-two
https://devblogs.microsoft.com/windows-music-dev/effectively-removing-the-fls-slot-allocation-limit-in-windows-10/

and difference with CI could be explained by FLS Slot Limit Increase in some Windows 10 build...

UPD: confirmed CI has FlsAlloc: 122 (mine limit is 4000+)

SSE4 added 2 commits January 21, 2022 23:14
Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 13 (7ba69697ca84b23acabc092ffc4374183e570da3):

  • gst-plugins-good/1.19.1@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants