- [cairo] ensure cairo-gobject.dll is copied #7732
Conversation
Signed-off-by: SSE4 <tomskside@gmail.com>
| @@ -206,14 +206,17 @@ def package(self): | |||
| self.copy(pattern="cairo-pdf.h", dst=inc, src=src) | |||
| self.copy(pattern="cairo-svg.h", dst=inc, src=src) | |||
| self.copy(pattern="cairo-gobject.h", dst=inc, src=cairo_gobject) | |||
| if self.options["glib"].shared: | |||
There was a problem hiding this comment.
I guess this means that the following is required: self.options.shared == self.options["glib"].shared.
Don't we need to add that check to validate and just keep using self.options.shared here?
There was a problem hiding this comment.
right now I am not sure if these two options orthogonal or must be in sync
There was a problem hiding this comment.
It really surprises me that copying (or not) these libraries depends on an option of a requirement... for example, if cairo is static, the file *cairo-gobject.dll is probably not generated, and it doesn't depend on the value of glib.shared.
There was a problem hiding this comment.
the following patch builds shared cairo-gobject.dll unconditionally.
maybe it depends neither on cairo:shared nor glib:shared?
I was able to trace patch to bincrafters/conan-cairo@0b0a354, added by @ericLemanissier 2 years ago.
no idea if it was taken from mail list or somewhere else, trying to find its roots...
There was a problem hiding this comment.
or maybe we should just switch to meson for cairo?
There was a problem hiding this comment.
I did not real the full thread, but I think the patch comes from https://gitlab.freedesktop.org/cairo/cairo/-/issues/75
There was a problem hiding this comment.
I would say "Use Meson instead", yes, but I may be slightly biased in this respect :)
I think it's a much better and more maintainable approach though which doesn't require hardcoding specific configuration choices either.
I would go as far as wondering whether the Makefile.win32 should just be removed seeing that it was last touched in 2012.
Just a heads-up that upstream cairo is working towards dropping support for all non-Meson build systems.
probably, we should just switch to meson as well
There was a problem hiding this comment.
if it works, it's clearly a better choice indeed
|
I detected other pull requests that are modifying cairo/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
for #7691
Specify library name and version: cairo/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.