-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libx264: Fix Android build #24587
libx264: Fix Android build #24587
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 3 ( |
Trying to build this package from windows I have compile-time errors: Logs
conanautotoolstoolchain.sh
conanautotoolstoolchain.sh
conanbuildenv-debug-armv8.sh
|
Summary
Changes to recipe: libx264/cci.20220602
Motivation
The issue #23718 reported an error when trying to build for Android. Plus, libx264 is a ffmpeg dependency.
Details
When using Conan android-ndk, most of things are configured already, like ndk_path and sysroot, but still misses the toolchain path (folder level with bin, sysroot, lib, ...). That level is really important because libx264 will ask for
strings
and same isllvm-strings
in Android NDK, it's the executable for strings in the NDK.The toolchain path looks fragile, but is stable, same adopted in the recipe for Android NDK, and checked locally with Android NDK 26d.
As I needed to execute several builds using Android NDK, I posted the build logs here: https://gist.github.com/uilianries/f3ca036501f9c175312fb7c7df614db2
Related to #24566
fixes #23718