Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libx264: Fix use of self_settings_build #26100

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Dec 4, 2024

In this PR, self._settings_build was introduced, but not defined. I'm not certain how it passed CI, but this should be self.settings_build.

Fixes #26098

@valenotary
Copy link

Thanks @Ahajha ! yeah im curious how this passed CI in the first place...

@Ahajha
Copy link
Contributor Author

Ahajha commented Dec 4, 2024

My only guess is that the branch in question is only for Android, so maybe it just got skipped over.

@uilianries
Copy link
Member

@Ahajha Hello! Thank for providing this hotfix quickly. Indeed I made some mistake when pushing that PR, because my build logs were working fine when cross-building from Linux to Android (see https://gist.github.com/uilianries/f3ca036501f9c175312fb7c7df614db2). Probably I forgot to push more code 😞 . I just checked locally again and current recipe in the master branch is broken for Android (log below) and when applying your fix, it's working fine again.

Current build log (master branch): libx264-cci.20240224-android-static.log

PR build log (commit d5c3d11): libx264-cci.20240224-android-static-pr.log

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _settings_build is no longer needed, because is an idiom used for Conan 1.x when building using a single profile (before Conan 1.24). The settings_build should be always available.

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue! Your help is greatly appreciated. 😊

@jcar87 jcar87 merged commit 1b3d4bb into conan-io:master Dec 5, 2024
10 checks passed
@Ahajha Ahajha deleted the ahajha/fix-libx264 branch December 5, 2024 20:41
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] libx264/cci.20240224: undefined attribute self._settings_build
5 participants