-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffmpeg] Fix Android build by disabling dependencies #24566
[ffmpeg] Fix Android build by disabling dependencies #24566
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 11bc994ffmpeg/6.1.1@#2d6f03a68b103aad23458327dda097d7
ffmpeg/6.1@#32ca4b91e8c9b4030f362590c7bfe64e
ffmpeg/6.0.1@#53bc1584038590f18db66b519ca460ea
ffmpeg/5.0.3@#485feb8e64cc260bf2cdaace4ccea680
ffmpeg/4.4.4@#fcb2520360398b97ec9669284ccf49b2
ffmpeg/5.1.3@#77506dc43294cd09d1dfe73fc5dc4151
|
I'll wait for #24564 first, so any further build should work with Android. |
9b8fc79
to
62eaf67
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
e5cb327
to
8234aba
Compare
This comment has been minimized.
This comment has been minimized.
Finally building for Android with updated dependencies! Here are some logs: |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 057b27effmpeg/6.1.1@#e25024ce996105d3fe5fdfb7bd9648f5
ffmpeg/6.1@#4b3b455bd70ff9a497ffdd06badd1433
ffmpeg/6.0.1@#8f73b804d0933f1c118e4ca3cf08be71
ffmpeg/7.0.1@#1c501f73055f1645254bfd710b5bfeac
ffmpeg/5.0.3@#a6359bebfa6f291c7cd8f35156fbc5e7
ffmpeg/4.4.4@#675a4b4752212cc3f12dcd93af08dea7
ffmpeg/5.1.3@#8ee412ad3d15b63e255286ee306b8c34
|
Need to wait for #24861 first. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 77b74fbffmpeg/6.1.1@#226a467e128025462e2f191f08ee60fa
ffmpeg/6.1@#cb4ab711b5880d7b3a6fa5b9d8c7475d
ffmpeg/6.0.1@#13a054a526b136ebfd2ac726650a08ab
ffmpeg/7.0.1@#f6050a53eb24166fdd69999244ced1ca
ffmpeg/5.0.3@#b73cc8f24cc60fcc5b3b38267ec4d231
ffmpeg/5.1.3@#ce483b3457ac291629afc69cf94f1c27
ffmpeg/4.4.4@#83bbe3149487fa231918caddf8a52ba5
|
Merged. And now, we have all parts together ... Enter Exodia! |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit d854331ffmpeg/7.0.1@#dc1b22b8cc63252f531eab895433be52
ffmpeg/6.1.1@#0e11f661aba91e6d1327090db0341846
ffmpeg/6.1@#b0baf55676f56463073675a48d79faac
ffmpeg/5.1.3@#f2841b1a173ea9f34ad661e2647f81df
ffmpeg/6.0.1@#8fed4f1636c99ed4647131e2b9bed7aa
ffmpeg/4.4.4@#7b4eea971026bba47f2ff0fbfef90a90
ffmpeg/5.0.3@#ed3cafdb97c67b7720fff386e8cf8013
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Here are all Android build logs updated, following the commit 300726c: Recipe revision 8a78efc06468bfc8b00a78926dcc6363 ffmpeg-4.4.4-android-shared.log |
Conan v1 pipeline ✔️All green in build 19 (
|
Hooks produced the following warnings for commit 300726cffmpeg/6.1.1@#8a78efc06468bfc8b00a78926dcc6363
ffmpeg/6.0.1@#634b2db1d37f9d29d89b741e7132584b
ffmpeg/6.1@#d711645f40a8decb9f7c0217f8828f55
ffmpeg/7.0.1@#1641af13f41b97839edf1c64e55f4079
ffmpeg/4.4.4@#4a8420d12e27d959e07b23c9b06c650b
ffmpeg/5.0.3@#bb47aee324ce79e67f7cd51de6aad6ff
ffmpeg/5.1.3@#a737d4d3a3ab12ff7d6b22b5faee80e9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job :)
* Disable libfdk_aac when building Android Signed-off-by: Uilian Ries <uilianries@gmail.com> * Remove libvpx validate Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix link Signed-off-by: Uilian Ries <uilianries@gmail.com> * bump libvpx version Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
Summary
Changes to recipe: ffmpeg/4.4.4
Motivation
Several issues involving ffmpeg and Android build: #23724 #23729 #23721 #18474 #23728 #23718 #20511
The
ffmpeg
works fine when building to Android, the problem are some dependencies that are not well supported on Android and are enabled by default.This PR remove those projects that are not supported on Android or have known bug in the upstream. I removed
libfdk_aac
andlibx265
as dependencies, both does not work on Android.The build log is available here: https://gist.github.com/uilianries/dc9906dfb1b28f3bbfb25aefecb7dbaf#file-android-clang17-build-log
The openh264 has a separated PR to fix Android support: #24564
Details
The
libfdk_aac
fails when build using Android NDK: https://gist.github.com/uilianries/dc9906dfb1b28f3bbfb25aefecb7dbaf#file-libfdk_aac-android-build-logIt's a known bug:
The
libx265
also fails when building for Android: https://gist.github.com/uilianries/dc9906dfb1b28f3bbfb25aefecb7dbaf#file-libx265-android-build-logThe upstream has related issues:
fixes #23729
fixes #18474
fixes #23728
fixes #20511
As ffmpeg has several dependencies that are affecting its Android build, these PRs should be merged first: