Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading crashpad to Conan 2 #24320

Merged
merged 42 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
db98b83
upgrading to Conan 2
memsharded Jun 13, 2024
ae287bd
clean yaml
memsharded Jun 13, 2024
839253e
removed from config.yml
memsharded Jun 13, 2024
b42cab1
Cleanup
AbrilRBS Jun 13, 2024
fce050f
use tool_requires
memsharded Jun 14, 2024
c48956e
wip
memsharded Jun 14, 2024
2e39705
(#24282) bump boost dependency
Jean1995 Jun 12, 2024
e59a806
(#23502) (#23474) simdjson/3.9.1: remove unnecessary constraints
Jie-Cheng Jun 12, 2024
5ac3fc6
(#18680) kealib: migrate to Conan v2
valgur Jun 12, 2024
b7bb988
(#19228) msix: migrate to Conan v2
valgur Jun 12, 2024
4b794e5
(#24296) cpp-httplib: add version 0.16.0
toge Jun 12, 2024
321f03b
(#24297) glaze: add version 2.8.1
toge Jun 12, 2024
b746352
(#24106) arrow: fix target names
robomics Jun 12, 2024
8a359e4
(#24307) libftp: add version 0.5.1
toge Jun 13, 2024
bbe9e45
(#24298) [sentry-native] Add versions 0.7.5/0.7.6 and remove 0.7.1/0.7.2
MartinDelille Jun 13, 2024
4ac9b22
(#24309) glaze: add version 2.8.2
toge Jun 13, 2024
20969c1
Update PULL_REQUEST_TEMPLATE.md (#24311)
jcar87 Jun 13, 2024
e87e777
(#24308) octo-logger-cpp: fix checksum for 1.12.0
toge Jun 13, 2024
5143496
(#22456) proposal: update dependencies
toge Jun 13, 2024
66693ed
(#18949) userspace-rcu: migrate to Conan v2
valgur Jun 13, 2024
da8b387
(#18986) librhash: migrate to Conan v2
valgur Jun 13, 2024
2d7ad6d
(#18950) pbc: migrate to Conan v2
valgur Jun 13, 2024
0f4d5fe
(#18948) hiredis/0.x.x: remove 0.x recipe
valgur Jun 13, 2024
d6950a5
(#23997) mini: add recipe
toge Jun 13, 2024
3dd8df8
(#24300) octo-logger-cpp: bumped fmt dependency
perseoGI Jun 13, 2024
af6da8a
(#20586) pcre2: fix invalid pcre2-config output for static libs
valgur Jun 13, 2024
01a2607
(#19239) pro-mdnsd: migrate to Conan v2
valgur Jun 13, 2024
ff12338
(#24262) reflect-cpp: add option for using with msgpack
uyha Jun 13, 2024
0e48b3e
(#24011) arrow: add version 16.1.0
toge Jun 13, 2024
3851ed8
(#24312) [bot] Update authorized users list (2024-06-13)
conan-center-bot Jun 13, 2024
6966b76
(#24273) [boost] Add -fcoroutines for GCC10 only
uilianries Jun 13, 2024
2889599
(#24318) glaze: add version 2.8.4
toge Jun 13, 2024
0e63efe
(#24316) jsoncons: add version 0.176.0
toge Jun 13, 2024
81c00c5
(#24306) libmaxminddb: add version 1.10.0
toge Jun 14, 2024
157dbcd
(#24323) pcre2: add version 10.44
toge Jun 14, 2024
a7d57bd
test pr do not merge
jcar87 Jun 14, 2024
9024e13
Revert "test pr do not merge"
jcar87 Jun 14, 2024
b8b3cc7
(#24328) change gn validate to validate_build
memsharded Jun 14, 2024
a9e36b4
Merge branch 'master' into upgrade2/crashpad
memsharded Jun 14, 2024
0968e42
package license
memsharded Jun 14, 2024
9fe418e
update to set_property for cmake_build_modules
memsharded Jun 14, 2024
b826c64
add library type
memsharded Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 1 addition & 31 deletions recipes/crashpad/all/conandata.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
sources:
"cci.20210507":
crashpad:
url: "https://github.com/chromium/crashpad/archive/d9bc7cf06aef74e928f9afc3dee33b60121b9c73.tar.gz"
sha256: "49f4b10f1de9b6d33743eccecace6b0fc9d7fe92e5e550ba5e099e6db9a11f0f"
mini_chromium:
url: "https://github.com/chromium/mini_chromium/archive/ccb198907cecf072d8f5b2543d4d348e834a298a.tar.gz"
sha256: "f40a77a4580cd1cb9af71602917a0e85b62bf0f74641b6ed81dd9fb2f2012ea9"
"cci.20220219":
crashpad:
url: "https://github.com/chromium/crashpad/archive/e9937cb36cd12f24d73a07c4b91168cf1885b5db.tar.gz"
Expand All @@ -14,36 +7,13 @@
url: "https://github.com/chromium/mini_chromium/archive/822fada4a9972e3e2f36a981da770539025beb0a.tar.gz"
sha256: "2c3bf30d324fcb60eeef84dd6aaf7fb75b70e37bdb3716ab3ea10cda51c4b05c"
patches:
"cci.20210507":
- patch_file: "patches/cci.20210507-0001-fix-openssl-link-order.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0002-remove-fPIC-Werror-LTO.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0003-compilers-from-env.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0004-use-conan-linux-syscall-support-package.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0005-allow-all-archs.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0006-mini_chromium-win_helper-py3.patch"
base_path: "source_subfolder"
- patch_file: "patches/cci.20210507-0007-use-system-zlib.patch"
base_path: "source_subfolder"
"cci.20220219":
- patch_file: "patches/cci.20220219-0001-fix-openssl-link-order.patch"

Check warning on line 11 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 11)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0002-remove-fPIC-Werror-LTO.patch"

Check warning on line 12 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 12)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0003-compilers-from-env.patch"

Check warning on line 13 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 13)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0004-use-conan-linux-syscall-support-package.patch"

Check warning on line 14 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 14)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0005-allow-all-archs.patch"

Check warning on line 15 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 15)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0006-mini_chromium-win_helper-py3.patch"
base_path: "source_subfolder"
# reused patch from cci.20210507
# reused patch from cci.20210507

Check warning on line 17 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 16)
- patch_file: "patches/cci.20210507-0007-use-system-zlib.patch"

Check warning on line 18 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2021 ... ^ (line: 18)
base_path: "source_subfolder"
- patch_file: "patches/cci.20220219-0007-static-lib-tool_support.patch"

Check warning on line 19 in recipes/crashpad/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/cci.2022 ... ^ (line: 19)
base_path: "source_subfolder"
208 changes: 94 additions & 114 deletions recipes/crashpad/all/conanfile.py

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

9 changes: 4 additions & 5 deletions recipes/crashpad/all/test_package/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
cmake_minimum_required(VERSION 3.1)
project(test_package)
cmake_minimum_required(VERSION 3.15)
project(test_package LANGUAGES CXX)

include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
conan_basic_setup()
find_package(crashpad REQUIRED CONFIG)

add_executable(${PROJECT_NAME} test_package.cpp)
target_link_libraries(${PROJECT_NAME} ${CONAN_LIBS})
target_link_libraries(${PROJECT_NAME} PRIVATE crashpad::crashpad)
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 17)
38 changes: 26 additions & 12 deletions recipes/crashpad/all/test_package/conanfile.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,39 @@
from conans import ConanFile, CMake, tools
from conan import ConanFile
from conan.tools.build import can_run
from conan.tools.cmake import cmake_layout, CMake
from conan.tools.files import mkdir, save, load
import os


class TestPackageConan(ConanFile):
settings = "os", "compiler", "build_type", "arch"
generators = "cmake"
settings = "os", "arch", "compiler", "build_type"
generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv"
test_type = "explicit"

def requirements(self):
self.requires(self.tested_reference_str)

def layout(self):
cmake_layout(self)

def generate(self):
save(self, os.path.join(self.generators_folder, "bindir"),
os.path.join(self.dependencies["crashpad"].package_folder, "bin"))

def build(self):
cmake = CMake(self)
cmake.configure()
cmake.build()

def test(self):
if not tools.cross_building(self):
if can_run(self):
test_env_dir = "test_env"
tools.mkdir(test_env_dir)
bin_path = os.path.join("bin", "test_package")
handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler"
handler_bin_path = os.path.join(self.deps_cpp_info["crashpad"].rootpath, "bin", handler_exe)
self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_bin_path), run_environment=True)
mkdir(self, test_env_dir)
bin_path = os.path.join(self.cpp.build.bindir, "test_package")
bindir = load(self, os.path.join(self.generators_folder, "bindir"))
handler_exe = "crashpad_handler" + (".exe" if self.settings.os == "Windows" else "")
handler_bin_path = os.path.join(bindir, handler_exe)
self.run(f"{bin_path} {test_env_dir}/db {handler_bin_path}", env="conanrun")
if self.settings.os == "Windows":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code that this is building is way too much for my linking, it even creates a localhost listener. I want to gets this PR merged soon, so won't block on it, but it would be nice to come back to the recipe to clean the test package up :)

handler_exe = "crashpad_handler.com"
handler_bin_path = os.path.join(self.deps_cpp_info["crashpad"].rootpath, "bin", handler_exe)
self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_bin_path), run_environment=True)
handler_bin_path = os.path.join(bindir, "crashpad_handler.com")
self.run(f"{bin_path} {test_env_dir}/db {handler_bin_path}", env="conanrun")
2 changes: 0 additions & 2 deletions recipes/crashpad/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
versions:
"cci.20210507":
folder: all
"cci.20220219":
folder: all
Loading