Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading crashpad to Conan 2 #24320

Merged
merged 42 commits into from
Jun 17, 2024

Conversation

memsharded
Copy link
Member

Summary

Changes to recipe: crashpad/cci.20220219

Dropping older 2021 version.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Jun 13, 2024
license = "Apache-2.0"
homepage = "https://chromium.googlesource.com/crashpad/crashpad/+/master/README.md"
provides = "crashpad", "mini_chromium"
provides = "mini_chromium"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing package_type, but I actually don't know what would fit best here. I guess library even though it also exposes bins

recipes/crashpad/all/conanfile.py Show resolved Hide resolved
bindir = load(self, os.path.join(self.generators_folder, "bindir"))
handler_exe = "crashpad_handler" + (".exe" if self.settings.os == "Windows" else "")
handler_bin_path = os.path.join(bindir, handler_exe)
self.run(f"{bin_path} {test_env_dir}/db {handler_bin_path}", env="conanrun")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code that this is building is way too much for my linking, it even creates a localhost listener. I want to gets this PR merged soon, so won't block on it, but it would be nice to come back to the recipe to clean the test package up :)

@conan-center-bot

This comment has been minimized.

memsharded and others added 19 commits June 14, 2024 16:32
* kealib: migrate to Conan v2

* kealib: transitive_libs=True

* kealib: simplify patch

* kealib: add v1.5.1

* kealib: bump hdf5

* kealib: add min cppstd check

* kealib: require GCC 6+

* kealib: drop v1.4.13

* kealib: bump to 1.5.2

* kealib: bump to 1.4.15

* kealib: fix MSVC lib name

* kealib: bump hdf5

* kealib: fix MSVC library names

* kealib: set HDF5_THREADSAFE based on hdf5 option

* kealib: restore GCC 5 support

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* kealib: fix a recipe bug

* kealib: add CMAKE_POLICY_DEFAULT_CMP0077

* kealib: use valid_min_cppstd()

* kealib: add cxx_std_11 to test_package

* Add missing system lib in windows

* Improve invalid config message.

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
* msix: migrate to Conan v2

* msix: use OpenSSL v1

* msix: bump deps

* msix: fix Clang build issue

* msix: fix OpenSSL 3 support

* msix: add missing system libs

* msix: simplify xml_parser option

* msix: Clang 12 is not supported

* msix: yaml

* msix: test_package cxx_std_14
* Use the same CMake target names as upstream

* Bugfix

* Bugfix

* Remove redundant calls to set_property("cmake_target_name")

* Revert "Remove redundant calls to set_property("cmake_target_name")"

This reverts commit fc113f0.

* Bugfix

* Bugfix
Update PR template:

- Mention list of PRs by recipe
- Simplify wording around testing locally
- request that PRs are motivated and detailed (what/why/how)
* proposal: update dependencies

* Update recipes/proposal/all/conanfile.py

* Update recipes/proposal/all/conanfile.py

* Update recipes/proposal/all/conanfile.py

* proposal: build fewer versions

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
* userspace-rcu: migrate to Conan v2

* userspace-rcu: add v0.14.0

* userspace-rcu: no need for a custom bootstrap script

* userspace-rcu: fix test_v1_package

* userspace-rcu: disable apple-clang for v0.11.4
* librhash: migrate to Conan v2

* librhash: use OpenSSL v1

* librhash: bump deps

* librhash: fix installation

* librhash: downgrade OpenSSL

* librhash: switch to custom CMakeLists.txt

The build scripts in the project are quite non-standard and not too portable.

Based on rhash/RHash#103

* librhash: bump openssl

* librhash: add v1.4.4

* librhash: fix the list of sources used in CMakeLists.txt

* librhash: fix missing lib prefix for libs

* librhash: don't use PROJECT_NAME
* pbc: migrate to Conan v2

* pbc: bump gmp

* pbc: use winflexbison on Windows

* pbc: add transitive_headers=True to gmp

* pbc: fix build

* pbc: fix apple cross building bug

* pbc: transitive_libs=True

* pbc: bump deps

* pbc: fix configure issue

* pbc: fix to_apple_arch()

* pbc: add MSVC support

* pbc: add AutotoolsDeps workaround for MSVC

* pbc: add MSVC ./configure workarounds

* pbc: not compatible with MSVC due to use of GNU extensions

* pbc: fix_apple_shared_install_name()
* hiredis/0.x.x: migrate to Conan v2

* hiredis/0.x.x: fix_apple_shared_install_name(self)

* Dropped support for very old 0.x.x versions

---------

Co-authored-by: PerseoGI <perseog@jfrog.com>
conan-center-bot and others added 9 commits June 14, 2024 16:32
Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com>
* Add -fcoroutines for GCC10 only

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Use b2 ranged version

Signed-off-by: Uilian Ries <uilianries@gmail.com>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
* libmaxmind: add version 1.10.0

* add with_binaries option

* Cleanups

* append PATH on with_binaries=True

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 0968e42
crashpad/cci.20220219@#a08903432ed29c00d1fd64ecc22670ac
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["mini_chromium_base"].build_modules is not a dictionary
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] cpp_info.components["mini_chromium_base"].build_modules is not a dictionary

@memsharded memsharded requested a review from AbrilRBS June 14, 2024 15:50
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (b826c64e1b4321d2bc3f19c0741d962a798cff54):

  • crashpad/cci.20220219:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (b826c64e1b4321d2bc3f19c0741d962a798cff54):

  • crashpad/cci.20220219:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5ba8f87 into conan-io:master Jun 17, 2024
14 checks passed
@memsharded memsharded deleted the upgrade2/crashpad branch June 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.