-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrading crashpad to Conan 2 #24320
Changes from all commits
db98b83
ae287bd
839253e
b42cab1
fce050f
c48956e
2e39705
e59a806
5ac3fc6
b7bb988
4b794e5
321f03b
b746352
8a359e4
bbe9e45
4ac9b22
20969c1
e87e777
5143496
66693ed
da8b387
2d7ad6d
0f4d5fe
d6950a5
3dd8df8
af6da8a
01a2607
ff12338
0e48b3e
3851ed8
6966b76
2889599
0e63efe
81c00c5
157dbcd
a7d57bd
9024e13
b8b3cc7
a9e36b4
0968e42
9fe418e
b826c64
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,4 @@ | ||
sources: | ||
"cci.20210507": | ||
crashpad: | ||
url: "https://github.com/chromium/crashpad/archive/d9bc7cf06aef74e928f9afc3dee33b60121b9c73.tar.gz" | ||
sha256: "49f4b10f1de9b6d33743eccecace6b0fc9d7fe92e5e550ba5e099e6db9a11f0f" | ||
mini_chromium: | ||
url: "https://github.com/chromium/mini_chromium/archive/ccb198907cecf072d8f5b2543d4d348e834a298a.tar.gz" | ||
sha256: "f40a77a4580cd1cb9af71602917a0e85b62bf0f74641b6ed81dd9fb2f2012ea9" | ||
"cci.20220219": | ||
crashpad: | ||
url: "https://github.com/chromium/crashpad/archive/e9937cb36cd12f24d73a07c4b91168cf1885b5db.tar.gz" | ||
|
@@ -14,36 +7,13 @@ | |
url: "https://github.com/chromium/mini_chromium/archive/822fada4a9972e3e2f36a981da770539025beb0a.tar.gz" | ||
sha256: "2c3bf30d324fcb60eeef84dd6aaf7fb75b70e37bdb3716ab3ea10cda51c4b05c" | ||
patches: | ||
"cci.20210507": | ||
- patch_file: "patches/cci.20210507-0001-fix-openssl-link-order.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0002-remove-fPIC-Werror-LTO.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0003-compilers-from-env.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0004-use-conan-linux-syscall-support-package.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0005-allow-all-archs.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0006-mini_chromium-win_helper-py3.patch" | ||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20210507-0007-use-system-zlib.patch" | ||
base_path: "source_subfolder" | ||
"cci.20220219": | ||
- patch_file: "patches/cci.20220219-0001-fix-openssl-link-order.patch" | ||
Check warning on line 11 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0002-remove-fPIC-Werror-LTO.patch" | ||
Check warning on line 12 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0003-compilers-from-env.patch" | ||
Check warning on line 13 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0004-use-conan-linux-syscall-support-package.patch" | ||
Check warning on line 14 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0005-allow-all-archs.patch" | ||
Check warning on line 15 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0006-mini_chromium-win_helper-py3.patch" | ||
base_path: "source_subfolder" | ||
# reused patch from cci.20210507 | ||
# reused patch from cci.20210507 | ||
Check warning on line 17 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
- patch_file: "patches/cci.20210507-0007-use-system-zlib.patch" | ||
Check warning on line 18 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" | ||
- patch_file: "patches/cci.20220219-0007-static-lib-tool_support.patch" | ||
Check warning on line 19 in recipes/crashpad/all/conandata.yml GitHub Actions / Lint changed files (YAML files)conandata.yml schema warning
|
||
base_path: "source_subfolder" |
Large diffs are not rendered by default.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.1) | ||
project(test_package) | ||
cmake_minimum_required(VERSION 3.15) | ||
project(test_package LANGUAGES CXX) | ||
|
||
include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) | ||
conan_basic_setup() | ||
find_package(crashpad REQUIRED CONFIG) | ||
|
||
add_executable(${PROJECT_NAME} test_package.cpp) | ||
target_link_libraries(${PROJECT_NAME} ${CONAN_LIBS}) | ||
target_link_libraries(${PROJECT_NAME} PRIVATE crashpad::crashpad) | ||
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 17) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,39 @@ | ||
from conans import ConanFile, CMake, tools | ||
from conan import ConanFile | ||
from conan.tools.build import can_run | ||
from conan.tools.cmake import cmake_layout, CMake | ||
from conan.tools.files import mkdir, save, load | ||
import os | ||
|
||
|
||
class TestPackageConan(ConanFile): | ||
settings = "os", "compiler", "build_type", "arch" | ||
generators = "cmake" | ||
settings = "os", "arch", "compiler", "build_type" | ||
generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv" | ||
test_type = "explicit" | ||
|
||
def requirements(self): | ||
self.requires(self.tested_reference_str) | ||
|
||
def layout(self): | ||
cmake_layout(self) | ||
|
||
def generate(self): | ||
save(self, os.path.join(self.generators_folder, "bindir"), | ||
os.path.join(self.dependencies["crashpad"].package_folder, "bin")) | ||
|
||
def build(self): | ||
cmake = CMake(self) | ||
cmake.configure() | ||
cmake.build() | ||
|
||
def test(self): | ||
if not tools.cross_building(self): | ||
if can_run(self): | ||
test_env_dir = "test_env" | ||
tools.mkdir(test_env_dir) | ||
bin_path = os.path.join("bin", "test_package") | ||
handler_exe = "crashpad_handler.exe" if self.settings.os == "Windows" else "crashpad_handler" | ||
handler_bin_path = os.path.join(self.deps_cpp_info["crashpad"].rootpath, "bin", handler_exe) | ||
self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_bin_path), run_environment=True) | ||
mkdir(self, test_env_dir) | ||
bin_path = os.path.join(self.cpp.build.bindir, "test_package") | ||
bindir = load(self, os.path.join(self.generators_folder, "bindir")) | ||
handler_exe = "crashpad_handler" + (".exe" if self.settings.os == "Windows" else "") | ||
handler_bin_path = os.path.join(bindir, handler_exe) | ||
self.run(f"{bin_path} {test_env_dir}/db {handler_bin_path}", env="conanrun") | ||
if self.settings.os == "Windows": | ||
handler_exe = "crashpad_handler.com" | ||
handler_bin_path = os.path.join(self.deps_cpp_info["crashpad"].rootpath, "bin", handler_exe) | ||
self.run("%s %s/db %s" % (bin_path, test_env_dir, handler_bin_path), run_environment=True) | ||
handler_bin_path = os.path.join(bindir, "crashpad_handler.com") | ||
self.run(f"{bin_path} {test_env_dir}/db {handler_bin_path}", env="conanrun") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
versions: | ||
"cci.20210507": | ||
folder: all | ||
"cci.20220219": | ||
folder: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that this is building is way too much for my linking, it even creates a localhost listener. I want to gets this PR merged soon, so won't block on it, but it would be nice to come back to the recipe to clean the test package up :)