-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google-cloud-cpp] add v2.23.0 version #23695
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6d23049
to
7737e94
Compare
This comment has been minimized.
This comment has been minimized.
7737e94
to
318b3e0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ping? |
@jcar87 PTAL |
@jcar87 - is there anything I need to do to get this PR merged? |
Hi @dbolduc - currently reviewing this, aiming to have a review today, thanks! |
ping? |
@jcar87 I remember that you've mentioned that based on the recent grpc update also google-cloud-cpp should be updated. Does it make sense that @dbolduc updates this to a newer version of google-cloud-cpp? Thanks for your effort @jcar87 and @dbolduc! Much appreciated. It would be great to have an updated google-cloud-cpp package. |
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
So then this PR should be closed? Are there any plans to create a google-cloud-cpp package which builds upon the newest grpc/1.65.0 and dependencies? |
Yes, thanks.
Not immediately. If it as simple as updating the |
google-cloud-cpp/2.23.0
google-cloud-cpp
.external/googleapis/
are always compiled googleapis/google-cloud-cpp#8022SelectMSVCRuntime.cmake
googleapis/google-cloud-cpp#13777Tested with the following on linux: