fix(compute): shorten paths for Bazel+MSVC #13836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC cannot handle paths over 254 characters. Bazel creates protobuf
generated files in (relatively) deep directories that include the name
of the proto library, and the path to the proto file (twice in our
case).
Using a single proto library for all the protos creates shorter paths.
We still have a duplicate `google/cloud/compute/${service}`, but at
least the target name is short.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13836 +/- ##
==========================================
- Coverage 93.64% 93.04% -0.61%
==========================================
Files 2258 2174 -84
Lines 195073 184802 -10271
==========================================
- Hits 182681 171945 -10736
- Misses 12392 12857 +465 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC cannot handle paths over 254 characters. Bazel creates protobuf generated files in (relatively) deep directories that include the name of the proto library, and the path to the proto file (twice in our case).
Using a single proto library for all the protos creates shorter paths. We still have a duplicate
google/cloud/compute/${service}, but at least the target name is short.Fixes #13835
This change is