Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove SelectMSVCRuntime.cmake #13777

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Mar 14, 2024

Vcpkg already contains this logic by itself and it might produce wrong results if vcpkg is not being used.


This change is Reviewable

@teo-tsirpanis teo-tsirpanis requested a review from a team as a code owner March 14, 2024 23:07
Copy link

google-cla bot commented Mar 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented Mar 14, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@devbww
Copy link
Contributor

devbww commented Mar 14, 2024

/gcbrun

@coryan coryan changed the title Delete SelectMSVCRuntime.cmake. cleanup: remove SelectMSVCRuntime.cmake Mar 14, 2024
@coryan coryan added the gha:full-build Trigger a full build in GHA label Mar 14, 2024
Vcpkg already contains this logic by itself and it might produce wrong results if vcpkg is not being used.
@devbww
Copy link
Contributor

devbww commented Mar 14, 2024

/gcbrun

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (033cda3) to head (5fb3979).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13777      +/-   ##
==========================================
- Coverage   93.20%   93.20%   -0.01%     
==========================================
  Files        2237     2237              
  Lines      193674   193674              
==========================================
- Hits       180522   180520       -2     
- Misses      13152    13154       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit f3d4abb into googleapis:main Mar 15, 2024
75 checks passed
@teo-tsirpanis teo-tsirpanis deleted the select-msvc-runtime branch March 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha:full-build Trigger a full build in GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants