-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: remove SelectMSVCRuntime.cmake
#13777
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
/gcbrun |
SelectMSVCRuntime.cmake
.SelectMSVCRuntime.cmake
Vcpkg already contains this logic by itself and it might produce wrong results if vcpkg is not being used.
c5f6b1e
to
5fb3979
Compare
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13777 +/- ##
==========================================
- Coverage 93.20% 93.20% -0.01%
==========================================
Files 2237 2237
Lines 193674 193674
==========================================
- Hits 180522 180520 -2
- Misses 13152 13154 +2 ☔ View full report in Codecov by Sentry. |
Vcpkg already contains this logic by itself and it might produce wrong results if vcpkg is not being used.
This change is