Add `loguru/2.1.0` recipe #14543

antekone · 2022-12-02T21:58:26Z

Loguru: a lightweight and flexible C++ logging library.

Website: https://emilk.github.io/loguru/index.html Source code: https://github.com/emilk/loguru

Specify library name and version: loguru/2.1.0

Loguru is a nice lightweight logging library. It has lots of stars on GitHub, and I think it should be supported by Conan. This is my first package so I'm sorry for any oversights!

I've read the contributing guidelines.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2022-12-02T21:58:33Z

All committers have signed the CLA.

uilianries

Thank you for your contribution, please, take a look on my review, there are some points which should be updated.

uilianries · 2022-12-12T12:18:33Z

recipes/loguru/all/CMakeLists.txt

@@ -0,0 +1,63 @@
+cmake_minimum_required(VERSION 3.25)


please, submit this cmake script to the upstream first.

Upstream already has a PR related to adding full CMake build: emilk/loguru#215, but it's not merged since April.

I can use the CMake script from this un-merged PR. But in the meantime I've decided to use a minimal own CMake script only for Conan package, and migrate to the "official" CMake build once upstream's PR-215 will be merged.

recipes/loguru/all/LICENSE.md

recipes/loguru/all/conanfile.py

uilianries · 2022-12-12T12:27:25Z

recipes/loguru/all/conanfile.py

+    def build_requirements(self):
+        self.tool_requires("cmake/3.25.0")
+


Suggested change

def build_requirements(self):

self.tool_requires("cmake/3.25.0")

it does not need cmake 3.25 for a very simple library.

Do you mean I should remove the cmake build requirement altogether? Or to downgrade its version?

I mean, it currently uses CMake to build itself. Can I still remove cmake build dependency?

recipes/loguru/all/conanfile.py

Loguru: a lightweight and flexible C++ logging library. Website: https://emilk.github.io/loguru/index.html Source code: https://github.com/emilk/loguru Closes conan-io#14542

stale · 2023-01-16T01:46:08Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

antekone · 2023-01-16T06:16:54Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I want to fix issues in this PR, but I'm waiting for feedback from the Conan team. Is there some kind "waiting for feedback" label that can be requested?

uilianries

@antekone Please, consider antekone#1

I added some improvements over your original cmake file 😄

stale · 2023-02-18T00:34:00Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Simplifications and Conan v2 fixes

antekone · 2023-03-01T08:01:25Z

@uilianries Merged your suggestions, thanks, will tidy up the latest comments from the linter bot (warnings regarding Conan v2) when I find some time for it.

uilianries · 2023-03-01T09:27:12Z

@antekone Thank you! Currently we are under maintenance due Conan v2 migration. Please, follow https://status.conan.io to get more information! Happy March!

stale · 2023-05-01T13:04:55Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2023-06-29T15:15:23Z

Hooks produced the following warnings for commit 9bdf511

loguru/cci.20230406

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libloguru.so' links to system library 'm' but it is not in cpp_info.system_libs.

conan-center-bot · 2023-07-01T11:56:41Z

Conan v1 pipeline ✔️

All green in build 18 (6c7c48b6f0c360d1ff5cd8368d174d77af0b6b43):

loguru/cci.20230406@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 18 (6c7c48b6f0c360d1ff5cd8368d174d77af0b6b43):

loguru/cci.20230406@:
All packages built successfully! (All logs)

czoido · 2023-07-03T05:30:57Z

Hi @antekone,
Looks like after some changes the recipe is almost there. Could you please sign the CLA so it can be merged after the last reviews?

antekone · 2023-07-03T05:33:21Z

@czoido CLA signed. I'm sorry for not participating in updates, and thank you for your help.

czoido · 2023-07-03T05:42:52Z

@czoido CLA signed. I'm sorry for not participating in updates, and thank you for your help.

No problem! Thanks a lot for the contribution! I hope the recipe can be merged soon

* Add `loguru/2.1.0` recipe Loguru: a lightweight and flexible C++ logging library. Website: https://emilk.github.io/loguru/index.html Source code: https://github.com/emilk/loguru Closes conan-io#14542 * Simplify CMake and native features usage (conan-io#1) Simplifications and Conan v2 fixes * Update recipes/loguru/all/conanfile.py * Update recipes/loguru/all/conanfile.py * Update recipes/loguru/all/conanfile.py * loguru: use latest commit with CMake support * fixup: missing comma * fixup: typo * chore: rm config files * fixup: clean up defines * add includedirs, simplify test_package * add suffix * add m * fix windows shared * remove pdbs --------- Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: czoido <mrgalleta@gmail.com>

conan-center-bot added the User-approval pending label Dec 2, 2022

This comment has been minimized.

Sign in to view

antekone mentioned this pull request Dec 2, 2022

[!!] Access request #4

Closed

github-actions bot mentioned this pull request Dec 2, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries reviewed Dec 12, 2022

View reviewed changes

Add loguru/2.1.0 recipe

9db2e89

Loguru: a lightweight and flexible C++ logging library. Website: https://emilk.github.io/loguru/index.html Source code: https://github.com/emilk/loguru Closes conan-io#14542

antekone force-pushed the package/loguru branch from f19f72b to 9db2e89 Compare December 12, 2022 18:03

conan-center-bot added Failed and removed User-approval pending labels Dec 12, 2022

This comment has been minimized.

Sign in to view

stale bot added the stale label Jan 16, 2023

stale bot removed the stale label Jan 16, 2023

uilianries reviewed Jan 16, 2023

View reviewed changes

stale bot added the stale label Feb 18, 2023

Simplify CMake and native features usage (#1)

04e99bc

Simplifications and Conan v2 fixes

stale bot removed the stale label Mar 1, 2023

conan-center-bot added Service Under Maintenance and removed Failed labels Mar 1, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Mar 29, 2023

This comment has been minimized.

Sign in to view

stale bot added the stale label May 1, 2023

This comment has been minimized.

Sign in to view

prince-chrismc added 2 commits May 10, 2023 09:19

fixup: missing comma

822dbae

fixup: typo

b3bca04

This comment has been minimized.

Sign in to view

chore: rm config files

bba9e2e

This comment has been minimized.

Sign in to view

fixup: clean up defines

634bf5f

This comment has been minimized.

Sign in to view

czoido self-assigned this Jun 29, 2023

add includedirs, simplify test_package

9bdf511

This comment has been minimized.

Sign in to view

czoido added 2 commits June 29, 2023 17:53

add suffix

f620f5d

add m

e2495f0

This comment has been minimized.

Sign in to view

fix windows shared

5f791ad

This comment has been minimized.

Sign in to view

remove pdbs

6c7c48b

conan-center-bot removed the Failed label Jul 1, 2023

czoido approved these changes Jul 3, 2023

View reviewed changes

prince-chrismc approved these changes Jul 3, 2023

View reviewed changes

conan-center-bot merged commit 31f8c57 into conan-io:master Jul 3, 2023

mologie mentioned this pull request Aug 13, 2023

loguru: fix preprocessor definition values #19179

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `loguru/2.1.0` recipe #14543

Add `loguru/2.1.0` recipe #14543

antekone commented Dec 2, 2022 •

edited

Loading

CLAassistant commented Dec 2, 2022 •

edited

Loading

This comment has been minimized.

uilianries left a comment

uilianries Dec 12, 2022

antekone Dec 12, 2022

uilianries Dec 12, 2022

antekone Dec 12, 2022

This comment has been minimized.

stale bot commented Jan 16, 2023

antekone commented Jan 16, 2023 •

edited

Loading

uilianries left a comment

stale bot commented Feb 18, 2023

This comment has been minimized.

antekone commented Mar 1, 2023 •

edited

Loading

uilianries commented Mar 1, 2023

This comment has been minimized.

stale bot commented May 1, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 29, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Jul 1, 2023

czoido commented Jul 3, 2023

antekone commented Jul 3, 2023

czoido commented Jul 3, 2023

		def build_requirements(self):
		self.tool_requires("cmake/3.25.0")

Add loguru/2.1.0 recipe #14543

Add loguru/2.1.0 recipe #14543

Conversation

antekone commented Dec 2, 2022 • edited Loading

CLAassistant commented Dec 2, 2022 • edited Loading

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

uilianries Dec 12, 2022

Choose a reason for hiding this comment

antekone Dec 12, 2022

Choose a reason for hiding this comment

uilianries Dec 12, 2022

Choose a reason for hiding this comment

antekone Dec 12, 2022

Choose a reason for hiding this comment

This comment has been minimized.

stale bot commented Jan 16, 2023

antekone commented Jan 16, 2023 • edited Loading

uilianries left a comment

Choose a reason for hiding this comment

stale bot commented Feb 18, 2023

This comment has been minimized.

antekone commented Mar 1, 2023 • edited Loading

uilianries commented Mar 1, 2023

This comment has been minimized.

stale bot commented May 1, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 29, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Jul 1, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

czoido commented Jul 3, 2023

antekone commented Jul 3, 2023

czoido commented Jul 3, 2023

Add `loguru/2.1.0` recipe #14543

Add `loguru/2.1.0` recipe #14543

antekone commented Dec 2, 2022 •

edited

Loading

CLAassistant commented Dec 2, 2022 •

edited

Loading

antekone commented Jan 16, 2023 •

edited

Loading

antekone commented Mar 1, 2023 •

edited

Loading