New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CMake and native features usage #1

Merged

antekone merged 4 commits into antekone:package/loguru from uilianries:package/loguru

Mar 1, 2023

uilianries commented Jan 16, 2023 •

edited by antekone

Loading

Some considerations related to your original PR:

Use BUILD_SHARED_LIBS from CMake, do not need a new shared/static option
Add fPIC option
Add option description in Cmake script
Export all definitions to consumer compiler
Use default values from upstream to configure arrays sizes

I've read the contributing guidelines.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.
Signed-off-by: Uilian Ries uilianries@gmail.com

uilianries added 4 commits

January 16, 2023 17:31


          Prepare for Conan v2

900ca25

Signed-off-by: Uilian Ries <uilianries@gmail.com>


          no verbose cmake

26f84c6

Signed-off-by: Uilian Ries <uilianries@gmail.com>


          simplify defines

3ae7512

Signed-off-by: Uilian Ries <uilianries@gmail.com>


          simplify defines

ee70084

Signed-off-by: Uilian Ries <uilianries@gmail.com>

antekone merged commit 04e99bc into antekone:package/loguru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet