Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loguru: fix preprocessor definition values #19179

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

mologie
Copy link
Contributor

@mologie mologie commented Aug 13, 2023

Loguru expects 0 or 1, but the recipe would set "False"/"True", which C's preprocessor would always evaluate to false.

Specify library name and version: loguru/*

PR #14543 added loguru, but improperly sets its preprocessor options. It sets the strings "False" or "True" as preprocessor definition due to quirks with how options are embedded. C's preprocessor evaluates both to false, so essentially all options are always off.

This PR sets 0 or 1 instead, so options can actually be toggled.


@conan-center-bot

This comment has been minimized.

Loguru expects 0 or 1, but the recipe would set "False"/"True", which
C's preprocessor would always evaluate to false.
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (ac64960633022f2d8db30e116b35c60bea7e2598):

  • loguru/cci.20230406@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (ac64960633022f2d8db30e116b35c60bea7e2598):

  • loguru/cci.20230406@:
    All packages built successfully! (All logs)

@czoido czoido self-assigned this Aug 17, 2023
@conan-center-bot conan-center-bot merged commit cfc4955 into conan-io:master Aug 18, 2023
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
Loguru expects 0 or 1, but the recipe would set "False"/"True", which
C's preprocessor would always evaluate to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants