loguru: fix preprocessor definition values #19179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loguru expects 0 or 1, but the recipe would set "False"/"True", which C's preprocessor would always evaluate to false.
Specify library name and version: loguru/*
PR #14543 added loguru, but improperly sets its preprocessor options. It sets the strings "False" or "True" as preprocessor definition due to quirks with how options are embedded. C's preprocessor evaluates both to false, so essentially all options are always off.
This PR sets 0 or 1 instead, so options can actually be toggled.