-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package] cpython/3.10.0: fails on Windows due to autoconf not in msys path #10028
Labels
bug
Something isn't working
Comments
jellespijker
pushed a commit
to Ultimaker/cura-build-environment
that referenced
this issue
Apr 1, 2022
CPython currently can't be build on our Windows build server. conan-io/conan-center-index#10028 @rburema and I did a test if it would be possible to use a system installed Python binaries. This seems to be possible. Contributes to CURA-8640
jellespijker
added a commit
to Ultimaker/conan-ultimaker-index
that referenced
this issue
Apr 6, 2022
conan-io/conan-center-index#10028 mpdecimals uses the automake package which relies on autoconf being on the msys2 path. Removed the mpdecimal as requirement when the compiler is Visual Studio. Contributes to CURA-8640
4 tasks
jellespijker
pushed a commit
to jellespijker/conan-center-index
that referenced
this issue
Jun 19, 2022
No need to compile mpdecimal with automake and msys2 on Windows. It will fail when compiling on Powershell otherwise, since autoconf seems to wrongly interpret environment variables (see also PR conan-io#11055). Removing the build_requirement allows it to compile for msvc and visual studio compiler. Fixes conan-io#10028
Wow that is convenient, you don't even need automake in the first place? Perhaps check my comment here: Perhaps if you |
jellespijker
added a commit
to Ultimaker/conan-ultimaker-index
that referenced
this issue
Aug 25, 2022
The wheels for PyQt6 from the pypi artifactory are linked against the limited Python ABI. The CPython interpreter we compile as part of Cura is not compiled with the Py_LIMITED_ABI flag. This results on Windows that the PyQt6 module try to use the python3.dll in the system, while our CPython deps is compiled as python310.dll. To make sure that PyQt6 runs and uses our CPython library we need to compile and link PyQt6 against our Conan dependencies. This means that we also need to compile Qt6 and make sure that PyQt6 is compiled without the Py_LIMITED_ABI definition. For this to work we need to patch the pyproject.toml (using our Conan pyprojecttoolchain generator https://github.com/Ultimaker/conan-ultimaker-index/blob/CURA-8831_pyqt6_recipe/recipes/pyprojecttoolchain/conanfile.py ) and patch the SIP definition files to replace all `use_limited_api=True` arguments with `use_limited_api=True`. Furthermore, we need enable at the very least the `qtdeclarative` module for Qml support. Adding the PyQt6/6.3.1 as a Conan dependency to Cura and Uranium and removing the PyQt6* requirements from the requirement.txt except: PyQt6-sip will solve the following GH issue Fixes Ultimaker/Cura#12773 Fixes Ultimaker/Cura#12745 Fixes Ultimaker/Cura#13047 Mind you we're still missing some PyQt6 modules atm so Cura will start up and doesn't complain about missing dll's anymore but at the time it doesn't render text yet. This is probably because harfbuzz and glib are disabled. These are currently disabled because of some issues with the Conan recipe for automake and autoconf when using msys2. See conan-io/conan-center-index#9048 and conan-io/conan-center-index#10028 A possible workaround for that is to modify the Qt6 dependency which uses automake and autoconf, remove those as dependencies when compiling on Windows and adding the option for: `msys2:packages=base-devel,binutils,gcc,autoconf,automake` Contributes to CURA-8831
4 tasks
Closed by #12715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package and Environment Details (include every applicable attribute)
Conan profile (output of
conan profile show default
orconan profile show <profile>
if custom profile is in use)Steps to reproduce (Include if Applicable)
Possible duplicate or at least related to #9048 and #9222
Logs (Include/Attach if Applicable)
Click to expand log
The text was updated successfully, but these errors were encountered: