Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[harfbuzz] Only check glib shared option if glib is a dependency #12619

Merged
merged 1 commit into from
Aug 30, 2022
Merged

[harfbuzz] Only check glib shared option if glib is a dependency #12619

merged 1 commit into from
Aug 30, 2022

Conversation

jellespijker
Copy link
Contributor

@jellespijker jellespijker commented Aug 26, 2022 •
edited
Loading

Fixes #12618

Specify library name and version: harfbuzz/all

Ran into this when I was going out of my way to not have to include glib in my chain of dependencies QT/6.3.1 because on Windows that would require gettext, which requires autoconf and automake, which I can't seem to build because autoconf is not on the PATH for msys2 #10028

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Aug 26, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 9430769
harfbuzz/3.0.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/3.1.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/4.2.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/4.0.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/4.1.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/5.1.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/4.4.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/3.2.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
harfbuzz/4.3.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libharfbuzz.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.

@prince-chrismc
Copy link
Contributor

please add the recipe name to the PR title 🙏

@jellespijker jellespijker changed the title Only check glib shared option if glib is a dependency [harfbuzz] Only check glib shared option if glib is a dependency Aug 26, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 3 (9430769c59f5870a179663b7d6c99d7b05cc2021):

  • harfbuzz/4.4.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/5.1.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/3.1.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/3.2.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/4.1.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/4.0.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/3.0.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/4.3.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • harfbuzz/4.2.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12619/recipes/harfbuzz/all/conanfile.py", line 4, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

@conan-center-bot conan-center-bot merged commit 0a0d4e1 into conan-io:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] harfbuzz/5.1.0: option["glib"] has no property shared when option.with_glib = False
5 participants
@jellespijker @conan-center-bot @prince-chrismc @uilianries @SpaceIm