Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msys2: conan v2 support #12715

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 31, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 4 (70b58530f1397030456069e3bde7b2687dd9c352):

  • msys2/cci.latest@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 70b5853
msys2/cci.latest
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\msys64\usr\lib\perl5\core_perl\auto\Win32\Win32.dll' links to system library 'version' but it is not in cpp_info.system_libs.

self.output.info(f"Creating MSYS_BIN env var : {msys_bin}")
self.buildenv_info.define_path("MSYS_BIN", msys_bin)

self.conf_info.define("tools.microsoft.bash:subsystem", "msys2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also experimenting with changing this recipe and using the buildenv_info, but I noticed that I needed to fix the subsystem.py for that to work correctly in consuming projects. See PR conan-io/conan#11981 and conan-io/conan#11980

I also still needed to keep on using the old env_info otherwise to much of my dependencies such as libffi needed to be overhauled. By defining them both I only needed to overhaul automake and autoconf. See: master...Ultimaker:conan-center-index:modernize_autoconf for a work in progress

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also still needed to keep on using the old env_info otherwise to much of my dependencies such as libffi needed to be overhauled. By defining them both I only needed to overhaul automake and autoconf. See: master...Ultimaker:conan-center-index:modernize_autoconf for a work in progress

related to conan-io/conan#11974 (comment)?

Copy link
Contributor Author

@SpaceIm SpaceIm Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact is that env_info must be kept for the moment in package_info() of CCI recipes, along buildenv_info, to achieve v1/v2 cross-compatibility. Because conan v1 recipes don't use at all buildenv_info of tool_requires, and even some conan v2 recipes (it depends on user configuration or if VirtualBuildEnv is explicitly used, see conan-io/conan#11974 (comment) again).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, will keep that in mind. You're updating those recipes at an amazing speed. I think that when I'm finally finished with my struggle getting CPython and Qt to compile on Windows, my change aren't needed anymore 😉.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jellespijker
Copy link
Contributor

PR #12777 is dependent on this PR

@jellespijker jellespijker mentioned this pull request Sep 4, 2022
4 tasks
@jellespijker
Copy link
Contributor

PR #12815 is also dependent on this PR

@jellespijker
Copy link
Contributor

#12834 is also depended on this PR

@uilianries
Copy link
Member

Up!

@conan-center-bot conan-center-bot merged commit e9b9393 into conan-io:master Sep 9, 2022
@SpaceIm SpaceIm deleted the msys2-conan-v2 branch September 9, 2022 12:41
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 26, 2022
* conan v2 support

* typo

* formatting

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants