-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msys2: conan v2 support #12715
msys2: conan v2 support #12715
Conversation
This comment has been minimized.
This comment has been minimized.
All green in build 4 (
|
Hooks produced the following warnings for commit 70b5853msys2/cci.latest
|
self.output.info(f"Creating MSYS_BIN env var : {msys_bin}") | ||
self.buildenv_info.define_path("MSYS_BIN", msys_bin) | ||
|
||
self.conf_info.define("tools.microsoft.bash:subsystem", "msys2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also experimenting with changing this recipe and using the buildenv_info
, but I noticed that I needed to fix the subsystem.py for that to work correctly in consuming projects. See PR conan-io/conan#11981 and conan-io/conan#11980
I also still needed to keep on using the old env_info
otherwise to much of my dependencies such as libffi
needed to be overhauled. By defining them both I only needed to overhaul automake and autoconf. See: master...Ultimaker:conan-center-index:modernize_autoconf for a work in progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also still needed to keep on using the old
env_info
otherwise to much of my dependencies such aslibffi
needed to be overhauled. By defining them both I only needed to overhaul automake and autoconf. See: master...Ultimaker:conan-center-index:modernize_autoconf for a work in progress
related to conan-io/conan#11974 (comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact is that env_info
must be kept for the moment in package_info()
of CCI recipes, along buildenv_info
, to achieve v1/v2 cross-compatibility. Because conan v1 recipes don't use at all buildenv_info
of tool_requires, and even some conan v2 recipes (it depends on user configuration or if VirtualBuildEnv
is explicitly used, see conan-io/conan#11974 (comment) again).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, will keep that in mind. You're updating those recipes at an amazing speed. I think that when I'm finally finished with my struggle getting CPython and Qt to compile on Windows, my change aren't needed anymore 😉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR #12777 is dependent on this PR |
PR #12815 is also dependent on this PR |
#12834 is also depended on this PR |
Up! |
* conan v2 support * typo * formatting * typo
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!