Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: option to reject previous builds and submissions on ASC submission #289

Merged
merged 34 commits into from
Feb 3, 2023
Merged

Feature: option to reject previous builds and submissions on ASC submission #289

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5b2ae7e
Add expire_previous_builds and cancel_previous_submissions actions
VeArnold Dec 1, 2022
c0a5e03
Remove cancel-submissions action
VeArnold Dec 1, 2022
124fcf4
Fix tests
VeArnold Dec 1, 2022
73b3ba3
Fix expire previous builds function
VeArnold Dec 2, 2022
d3bf1e6
Fix expiring build with modify
VeArnold Dec 2, 2022
965abcb
Amend
VeArnold Dec 2, 2022
25b3b90
Add new actions to cancel and expire all
VeArnold Dec 2, 2022
d8415da
Use not_expired instead of expired as a filter
VeArnold Dec 2, 2022
cda4337
Update changelog and pump version
VeArnold Dec 5, 2022
2815215
Update expire action and address comments
VeArnold Dec 5, 2022
bdd9114
Amend
VeArnold Dec 5, 2022
054ea47
Amend
VeArnold Dec 5, 2022
1b0444c
Fix types
VeArnold Dec 5, 2022
828dd1c
Fix default values in tests
VeArnold Dec 5, 2022
773e045
Sync abstractmethod
VeArnold Dec 5, 2022
d3169e0
Amend
VeArnold Dec 5, 2022
2d4a9fa
Fix list_review_submissions abstractmethod type
VeArnold Dec 5, 2022
b511ea9
Merge master into branch and refactor
VeArnold Jan 30, 2023
8ddc6e1
Remove None declaration for app id in review submissions
VeArnold Jan 30, 2023
dfa569a
Update src/codemagic/apple/app_store_connect/versioning/review_submis…
VeArnold Jan 30, 2023
dee7df8
Refactor as expire_builds and generate docs
VeArnold Jan 31, 2023
72cdaa7
Fix excepted build argument
VeArnold Jan 31, 2023
d56fc94
Fix docs
VeArnold Jan 31, 2023
91ac3a8
Refactor and add new options
VeArnold Feb 1, 2023
1c3f99d
Update changelog
VeArnold Feb 2, 2023
fba4664
Move action groups
VeArnold Feb 2, 2023
cc482c6
Move action groups
VeArnold Feb 2, 2023
489f3d3
Revert "Move action groups"
VeArnold Feb 2, 2023
35c5f5e
Move app specific actions to apps group
VeArnold Feb 2, 2023
0b358e8
Remove unused expire-builds flag
VeArnold Feb 2, 2023
b28cd99
Refactor submitting to app store with canceling prev
VeArnold Feb 2, 2023
d77a0cb
Fix incorrect types and refactor slightly
VeArnold Feb 2, 2023
c5b0fbd
Update docs
VeArnold Feb 2, 2023
df6310b
Update src/codemagic/__version__.py
VeArnold Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Amend
  • Loading branch information
@VeArnold
VeArnold committed Dec 5, 2022
commit d3169e038aeb840ee62dc04fefce09f4bcb60909
2 changes: 1 addition & 1 deletion src/codemagic/tools/_app_store_connect/abstract_base_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def expire_previous_builds(
@abstractmethod
def cancel_review_submissions(
self,
application_id: ResourceId = None,
application_id: ResourceId,
platform: Optional[Platform] = None,
review_submission_state: Optional[Union[ReviewSubmissionState, Sequence[ReviewSubmissionState]]] = None,
should_print: bool = False,
Expand Down