Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: option to reject previous builds and submissions on ASC submission #289

Merged
merged 34 commits into from
Feb 3, 2023
Merged

Feature: option to reject previous builds and submissions on ASC submission #289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5b2ae7e
Add expire_previous_builds and cancel_previous_submissions actions
VeArnold Dec 1, 2022
c0a5e03
Remove cancel-submissions action
VeArnold Dec 1, 2022
124fcf4
Fix tests
VeArnold Dec 1, 2022
73b3ba3
Fix expire previous builds function
VeArnold Dec 2, 2022
d3bf1e6
Fix expiring build with modify
VeArnold Dec 2, 2022
965abcb
Amend
VeArnold Dec 2, 2022
25b3b90
Add new actions to cancel and expire all
VeArnold Dec 2, 2022
d8415da
Use not_expired instead of expired as a filter
VeArnold Dec 2, 2022
cda4337
Update changelog and pump version
VeArnold Dec 5, 2022
2815215
Update expire action and address comments
VeArnold Dec 5, 2022
bdd9114
Amend
VeArnold Dec 5, 2022
054ea47
Amend
VeArnold Dec 5, 2022
1b0444c
Fix types
VeArnold Dec 5, 2022
828dd1c
Fix default values in tests
VeArnold Dec 5, 2022
773e045
Sync abstractmethod
VeArnold Dec 5, 2022
d3169e0
Amend
VeArnold Dec 5, 2022
2d4a9fa
Fix list_review_submissions abstractmethod type
VeArnold Dec 5, 2022
b511ea9
Merge master into branch and refactor
VeArnold Jan 30, 2023
8ddc6e1
Remove None declaration for app id in review submissions
VeArnold Jan 30, 2023
dfa569a
Update src/codemagic/apple/app_store_connect/versioning/review_submis…
VeArnold Jan 30, 2023
dee7df8
Refactor as expire_builds and generate docs
VeArnold Jan 31, 2023
72cdaa7
Fix excepted build argument
VeArnold Jan 31, 2023
d56fc94
Fix docs
VeArnold Jan 31, 2023
91ac3a8
Refactor and add new options
VeArnold Feb 1, 2023
1c3f99d
Update changelog
VeArnold Feb 2, 2023
fba4664
Move action groups
VeArnold Feb 2, 2023
cc482c6
Move action groups
VeArnold Feb 2, 2023
489f3d3
Revert "Move action groups"
VeArnold Feb 2, 2023
35c5f5e
Move app specific actions to apps group
VeArnold Feb 2, 2023
0b358e8
Remove unused expire-builds flag
VeArnold Feb 2, 2023
b28cd99
Refactor submitting to app store with canceling prev
VeArnold Feb 2, 2023
d77a0cb
Fix incorrect types and refactor slightly
VeArnold Feb 2, 2023
c5b0fbd
Update docs
VeArnold Feb 2, 2023
df6310b
Update src/codemagic/__version__.py
VeArnold Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs
  • Loading branch information
@VeArnold
VeArnold committed Feb 2, 2023
commit c5b0fbdc37a70ac096cae86536d402ffd307286c
2 changes: 2 additions & 0 deletions docs/app-store-connect/apps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ Enable verbose logging for commands
| :--- | :--- |
|[`cancel-review-submissions`](apps/cancel-review-submissions.md)|Find and cancel review submissions in App Store Connect for the given application|
|[`expire-builds`](apps/expire-builds.md)|Expire all application builds except the given build(s)|
|[`expire-build-submitted-for-review`](apps/expire-build-submitted-for-review.md)|Expire application build that is currently waiting for review, or is currently in review in TestFlight|
|[`get`](apps/get.md)|Get information about a specific app|
|[`builds`](apps/builds.md)|Get a list of builds associated with a specific app matching given constrains|
|[`pre-release-versions`](apps/pre-release-versions.md)|Get a list of prerelease versions associated with a specific app|
|[`app-store-versions`](apps/app-store-versions.md)|Get a list of App Store versions associated with a specific app|
|[`list`](apps/list.md)|Find and list apps added in App Store Connect|
|[`list-review-submissions`](apps/list-review-submissions.md)|Find and list review submissions in App Store Connect for the given application|
4 changes: 2 additions & 2 deletions docs/app-store-connect/apps/cancel-review-submissions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ app-store-connect apps cancel-review-submissions [-h] [--log-stream STREAM] [--n
[--private-key PRIVATE_KEY]
[--certificates-dir CERTIFICATES_DIRECTORY]
[--profiles-dir PROFILES_DIRECTORY]
[--platform PLATFORM]
[--platform PLATFORM_OPTIONAL]
[--review-submission-state REVIEW_SUBMISSION_STATE]
APPLICATION_ID_RESOURCE_ID
```
Expand All @@ -32,7 +32,7 @@ Application Apple ID. An automatically generated ID assigned to your app
##### `--platform, --app-store-version-platform=IOS | MAC_OS | TV_OS`


App Store Version platform. Default: `IOS`
App Store Version platform
##### `--review-submission-state=CANCELING | COMPLETE | COMPLETING | IN_REVIEW | READY_FOR_REVIEW | UNRESOLVED_ISSUES | WAITING_FOR_REVIEW`


Expand Down
4 changes: 2 additions & 2 deletions ...ilds/expire-build-submitted-for-review.md → ...apps/expire-build-submitted-for-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ expire-build-submitted-for-review
=================================


**Expire application build that is currently waiting for review, or is currently in review**
**Expire application build that is currently waiting for review, or is currently in review in TestFlight**
### Usage
```bash
app-store-connect builds expire-build-submitted-for-review [-h] [--log-stream STREAM] [--no-color] [--version] [-s] [-v]
app-store-connect apps expire-build-submitted-for-review [-h] [--log-stream STREAM] [--no-color] [--version] [-s] [-v]
[--log-api-calls]
[--api-unauthorized-retries UNAUTHORIZED_REQUEST_RETRIES]
[--api-server-error-retries SERVER_ERROR_RETRIES]
Expand Down
6 changes: 3 additions & 3 deletions ...ew-submissions/list-review-submissions.md → ...e-connect/apps/list-review-submissions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ list-review-submissions
**Find and list review submissions in App Store Connect for the given application**
### Usage
```bash
app-store-connect review-submissions list-review-submissions [-h] [--log-stream STREAM] [--no-color] [--version] [-s] [-v]
app-store-connect apps list-review-submissions [-h] [--log-stream STREAM] [--no-color] [--version] [-s] [-v]
[--log-api-calls]
[--api-unauthorized-retries UNAUTHORIZED_REQUEST_RETRIES]
[--api-server-error-retries SERVER_ERROR_RETRIES]
Expand All @@ -17,7 +17,7 @@ app-store-connect review-submissions list-review-submissions [-h] [--log-stream
[--private-key PRIVATE_KEY]
[--certificates-dir CERTIFICATES_DIRECTORY]
[--profiles-dir PROFILES_DIRECTORY]
[--platform PLATFORM]
[--platform PLATFORM_OPTIONAL]
[--review-submission-state REVIEW_SUBMISSION_STATE]
APPLICATION_ID_RESOURCE_ID
```
Expand All @@ -32,7 +32,7 @@ Application Apple ID. An automatically generated ID assigned to your app
##### `--platform, --app-store-version-platform=IOS | MAC_OS | TV_OS`


App Store Version platform. Default: `IOS`
App Store Version platform
##### `--review-submission-state=CANCELING | COMPLETE | COMPLETING | IN_REVIEW | READY_FOR_REVIEW | UNRESOLVED_ISSUES | WAITING_FOR_REVIEW`


Expand Down
1 change: 0 additions & 1 deletion docs/app-store-connect/builds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ Enable verbose logging for commands
| :--- | :--- |
|[`add-beta-test-info`](builds/add-beta-test-info.md)|Add localized What's new (what to test) information|
|[`expire`](builds/expire.md)|Expire a specific build, an expired build becomes unavailable for testing|
|[`expire-build-submitted-for-review`](builds/expire-build-submitted-for-review.md)|Expire application build that is currently waiting for review, or is currently in review|
|[`get`](builds/get.md)|Get information about a specific build|
|[`app`](builds/app.md)|Get the App details for a specific build.|
|[`app-store-version`](builds/app-store-version.md)|Get the App Store version of a specific build.|
Expand Down
1 change: 0 additions & 1 deletion docs/app-store-connect/review-submissions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,3 @@ Enable verbose logging for commands
|[`confirm`](review-submissions/confirm.md)|Confirm pending review submission for App Review|
|[`create`](review-submissions/create.md)|Create a review submission request for application's latest App Store Version|
|[`get`](review-submissions/get.md)|Read Review Submission information|
|[`list-review-submissions`](review-submissions/list-review-submissions.md)|Find and list review submissions in App Store Connect for the given application|
2 changes: 1 addition & 1 deletion src/codemagic/tools/_app_store_connect/abstract_base_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ def submit_to_app_store(
def submit_to_testflight(
self,
build_id: ResourceId,
expire_build_submitted_for_review: bool = False,
max_build_processing_wait: Optional[Union[int, Types.MaxBuildProcessingWait]] = None,
expire_build_submitted_for_review: bool = False,
) -> BetaAppReviewSubmission:
from .action_groups import BuildsActionGroup
_ = BuildsActionGroup.submit_to_testflight # Implementation
Expand Down
2 changes: 1 addition & 1 deletion src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ def add_beta_test_info(
def submit_to_testflight(
self,
build_id: ResourceId,
expire_build_submitted_for_review: bool = False,
max_build_processing_wait: Optional[Union[int, Types.MaxBuildProcessingWait]] = None,
expire_build_submitted_for_review: bool = False,
) -> BetaAppReviewSubmission:
"""
Submit build to TestFlight
Expand Down