Feature: option to reject previous builds and submissions on ASC submission #289

VeArnold · 2022-12-01T13:23:28Z

This PR aims to introduce a few enchantments to existing logic. Namely, if there's an active submission in either App Store or TestFlight, any further attempts to create new submissions will fail. In this PR, options are introduced to solve this issue for both App Store review and TestFlight review.

Updates to existing actions:

new option --beta-review-state for the action app-store-connect apps builds
new option --cancel-previous-submissions for the action app-store-connect builds submit-to-app-store
new option --expire-build-submitted-for-review for the action app-store-connect builds submit-to-testflight
new option --beta-review-state for the action app-store-connect list-builds
new options --expire-build-submitted-for-review and --cancel-previous-submissions for the action app-store-connect publish

Newly added actions:

app-store-connect apps expire-builds
app-store-connect builds app
app-store-connect apps expire-build-submitted-for-review
app-store-connect builds expire
app-store-connect apps cancel-review-submissions
app-store-connect apps list-review-submissions

QA:

build filtering with --beta-review-state (single and multiple values) ✅
build filtering for app-store-connect review-submissions list based on state ✅
review submissions are correctly listed (platform, state args function as wanted) ✅
canceling submissions accepts single and multiple types ✅
expire-builds expires all builds except the one passed as an argument ✅
expire-builds accepts multiple values ✅
expire targets a specific build and expires it ✅
expire-build-submitted-for-review only expires a build that is IN_REVIEW or WAITING_FOR_REVIEW state ✅
build is expired before creating submission ✅
app-store-connect builds app returns application info for given build ✅

Resolves #288.

priitlatt · 2022-12-01T13:47:55Z

Please update description with information about what actions were updated, removed and added.

pyproject.toml

src/codemagic/apple/app_store_connect/builds/builds.py

src/codemagic/apple/app_store_connect/versioning/review_submissions.py

src/codemagic/tools/_app_store_connect/abstract_base_action.py

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py

src/codemagic/tools/_app_store_connect/actions/publish_action.py

src/codemagic/tools/_app_store_connect/arguments.py

priitlatt

Maybe some things could be improved a little. Also we're missing updates to docs.

src/codemagic/apple/app_store_connect/versioning/review_submissions.py

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py

src/codemagic/tools/_app_store_connect/arguments.py

…sions.py Co-authored-by: Priit Lätt <priit@nevercode.io>

priitlatt

Needs some more work on it.

CHANGELOG.md

src/codemagic/apple/app_store_connect/versioning/review_submissions.py

src/codemagic/tools/_app_store_connect/abstract_base_action.py

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py

src/codemagic/tools/_app_store_connect/arguments.py

src/codemagic/tools/_app_store_connect/actions/publish_action.py

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py

This reverts commit cc482c6.

src/codemagic/tools/_app_store_connect/abstract_base_action.py

src/codemagic/tools/_app_store_connect/action_groups/apps_action_group.py

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py

src/codemagic/tools/_app_store_connect/actions/publish_action.py

src/codemagic/__version__.py

Co-authored-by: Priit Lätt <priit@nevercode.io>

priitlatt

No more complaints. Everything looks good.

priitlatt · 2023-02-02T15:22:06Z

@VeArnold, great job with this feature development! 👍

VeArnold added 3 commits December 1, 2022 19:19

Add expire_previous_builds and cancel_previous_submissions actions

5b2ae7e

Remove cancel-submissions action

c0a5e03

Fix tests

124fcf4

priitlatt self-requested a review December 1, 2022 13:48

priitlatt added the enhancement New feature or request label Dec 1, 2022

VeArnold added 5 commits December 2, 2022 17:14

Fix expire previous builds function

73b3ba3

Fix expiring build with modify

d3bf1e6

Amend

965abcb

Add new actions to cancel and expire all

25b3b90

Use not_expired instead of expired as a filter

d8415da

VeArnold marked this pull request as ready for review December 5, 2022 05:46

Update changelog and pump version

cda4337

priitlatt requested changes Dec 5, 2022

View reviewed changes

VeArnold added 10 commits December 5, 2022 18:39

Update expire action and address comments

2815215

Amend

bdd9114

Amend

054ea47

Fix types

1b0444c

Fix default values in tests

828dd1c

Sync abstractmethod

773e045

Amend

d3169e0

Fix list_review_submissions abstractmethod type

2d4a9fa

Merge master into branch and refactor

b511ea9

Remove None declaration for app id in review submissions

8ddc6e1

VeArnold requested a review from priitlatt January 30, 2023 14:12

priitlatt requested changes Jan 30, 2023

View reviewed changes

Update src/codemagic/apple/app_store_connect/versioning/review_submis…

dfa569a

…sions.py Co-authored-by: Priit Lätt <priit@nevercode.io>

VeArnold marked this pull request as draft January 31, 2023 13:07

VeArnold added 2 commits January 31, 2023 15:12

Refactor as expire_builds and generate docs

dee7df8

Fix excepted build argument

72cdaa7

VeArnold requested a review from priitlatt February 1, 2023 00:22

VeArnold assigned priitlatt and unassigned priitlatt Feb 1, 2023

Fix docs

d56fc94

VeArnold assigned priitlatt Feb 1, 2023

priitlatt requested changes Feb 1, 2023

View reviewed changes

VeArnold marked this pull request as draft February 1, 2023 18:19

VeArnold added 2 commits February 1, 2023 23:52

Refactor and add new options

91ac3a8

Update changelog

1c3f99d

VeArnold marked this pull request as ready for review February 2, 2023 01:00

VeArnold requested a review from priitlatt February 2, 2023 01:00

VeArnold added 2 commits February 2, 2023 12:12

Move action groups

fba4664

Move action groups

cc482c6

priitlatt reviewed Feb 2, 2023

View reviewed changes

src/codemagic/tools/_app_store_connect/action_groups/builds_action_group.py Outdated Show resolved Hide resolved

Revert "Move action groups"

489f3d3

This reverts commit cc482c6.

priitlatt reviewed Feb 2, 2023

View reviewed changes

src/codemagic/tools/_app_store_connect/abstract_base_action.py Outdated Show resolved Hide resolved

VeArnold added 3 commits February 2, 2023 12:38

Move app specific actions to apps group

35c5f5e

Remove unused expire-builds flag

0b358e8

Refactor submitting to app store with canceling prev

b28cd99

priitlatt requested changes Feb 2, 2023

View reviewed changes

VeArnold added 2 commits February 2, 2023 16:31

Fix incorrect types and refactor slightly

d77a0cb

Update docs

c5b0fbd

priitlatt reviewed Feb 2, 2023

View reviewed changes

src/codemagic/__version__.py Outdated Show resolved Hide resolved

Update src/codemagic/__version__.py

df6310b

Co-authored-by: Priit Lätt <priit@nevercode.io>

priitlatt approved these changes Feb 2, 2023

View reviewed changes

priitlatt removed their assignment Feb 2, 2023

VeArnold merged commit eb81dd2 into master Feb 3, 2023

VeArnold deleted the feature/reject-previous-app-store-builds branch February 3, 2023 07:21

VeArnold mentioned this pull request Feb 6, 2023

Remove existing builds from review with publish #288

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: option to reject previous builds and submissions on ASC submission #289

Feature: option to reject previous builds and submissions on ASC submission #289

VeArnold commented Dec 1, 2022 •

edited

Loading

priitlatt commented Dec 1, 2022

priitlatt left a comment

priitlatt left a comment

priitlatt left a comment

priitlatt commented Feb 2, 2023

Feature: option to reject previous builds and submissions on ASC submission #289

Feature: option to reject previous builds and submissions on ASC submission #289

Conversation

VeArnold commented Dec 1, 2022 • edited Loading

priitlatt commented Dec 1, 2022

priitlatt left a comment

Choose a reason for hiding this comment

priitlatt left a comment

Choose a reason for hiding this comment

priitlatt left a comment

Choose a reason for hiding this comment

priitlatt commented Feb 2, 2023

VeArnold commented Dec 1, 2022 •

edited

Loading