Markov Check, record lower recall nodes when plotting data #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdramsey
approved these changes
Jun 25, 2024
vbcwonderland
added a commit
that referenced
this pull request
Jun 25, 2024
jdramsey
added a commit
that referenced
this pull request
Jun 25, 2024
Padding for PR #1788 Markov Check, record lower recall nodes when plotting data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a hard coded value of
lowRecallBoundfor functions:getAndersonDarlingTestAcceptsRejectsNodesForAllNodesPlotData(fisherZTest, estimatedCpdag, trueGraph, 0.05, 1.0, 0.8)and
getAndersonDarlingTestAcceptsRejectsNodesForAllNodesPlotData2(fisherZTest, estimatedCpdag, trueGraph, 0.05, 1.0, 0.8)the examples above are setting the low recall bound as 0.8, which means all the low recalls strictly lower than this value would be recorded as a seperate list. The low record nodes are recorded in:
lowAdjRecallNodes.csv,lowAHRecallNodes.csv,lowLGRecallNodes.csv