Merge pull request #1789 from cmu-phil/vbc-2024-06-24-pd

Padding for PR #1788 Markov Check, record lower recall nodes when plotting data
cmu-phil · Jun 25, 2024 · 1a3a344 · 1a3a344
2 parents ad3edc4 + 0f2f6d8
commit 1a3a344
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/tetrad-lib/src/main/java/edu/cmu/tetrad/search/MarkovCheck.java b/tetrad-lib/src/main/java/edu/cmu/tetrad/search/MarkovCheck.java
@@ -407,6 +407,12 @@ public List<List<Node>> getAndersonDarlingTestAcceptsRejectsNodesForAllNodesPlot
             Double ar = ap_ar_ahp_ahr.get(1);
             Double ahp = ap_ar_ahp_ahr.get(2);
             Double ahr = ap_ar_ahp_ahr.get(3);
+            if (ar < lowRecallBound) {
+                lowAdjRecallNodes.add(x);
+            }
+            if (ahr < lowRecallBound) {
+                lowAHRecallNodes.add(x);
+            }
             if (!localIndependenceFacts.isEmpty()) {
                 // All local nodes' p-values for node x.
                 List<List<Double>> shuffledlocalPValues = getLocalPValues(independenceTest, localIndependenceFacts, shuffleThreshold); // shuffleThreshold default to be 0.5
@@ -570,6 +576,9 @@ public List<List<Node>> getAndersonDarlingTestAcceptsRejectsNodesForAllNodesPlot
             List<Double> lgp_lgr = getPrecisionAndRecallOnMarkovBlanketGraphPlotData2(x, estimatedCpdag, trueGraph);
             Double lgp = lgp_lgr.get(0);
             Double lgr = lgp_lgr.get(1);
+            if (lgr < lowRecallBound) {
+                lowLGRecallNodes.add(x);
+            }
             if (!localIndependenceFacts.isEmpty()) {
                 // All local nodes' p-values for node x.
                 List<List<Double>> shuffledlocalPValues = getLocalPValues(independenceTest, localIndependenceFacts, shuffleThreshold);