Added option to automatically allow access for Datapipeline controlled instance to the backed up EFS #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Aug 23, 2017
README.md
Outdated
| @@ -51,7 +46,8 @@ output "efs_backup_security_group" { | |||
| | name | `` | Name (e.g. `efs-backup`) | Yes | | |||
| | region | `us-east-1` | AWS Region where module should operate (e.g. `us-east-1`)| Yes | | |||
| | vpc_id | `` | AWS VPC ID where module should operate (e.g. `vpc-a22222ee`)| Yes | | |||
| | efs_ids | [] | List of EFS ID | Yes | | |||
| | efs_mount_target_id | `` | Elastic File System Mount Target (EFS) | Yes | | |||
| | change_security_group | `false` | Should the module modify EFS security groups | No | | |||
There was a problem hiding this comment.
rename to modify_security_group
There was a problem hiding this comment.
Change is confusing because it could mean you will replace the security group.
osterman
previously approved these changes
Aug 23, 2017
614a52a to
7418f0c
Compare
f9ebcfc to
7dcc42d
Compare
const-bon
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
aws_efs_mount_targetexists for each EFS and provides more info than the datasourceaws_efs_file_system. Also, we no longer need to remember that we should add an allow rule to EFS security groups.