Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed type of datasource to aws_efs_mount_target #2

Closed
wants to merge 3 commits into from
Closed

Changed type of datasource to aws_efs_mount_target #2

wants to merge 3 commits into from

Conversation

s2504s
Copy link
Contributor

@s2504s s2504s commented Aug 15, 2017 •
edited
Loading

What

  • Changed type of datasource from aws_efs_file_system to aws_efs_mount_target

Why

  • This change allow us to create EC2 instance with EFS's security groups. Now, we no longer needed to create an additional security group

@s2504s s2504s requested review from osterman and const-bon August 15, 2017 16:23
@s2504s s2504s self-assigned this Aug 15, 2017
@s2504s s2504s changed the title Added Changed type of datasource to aws_efs_mount_target Aug 15, 2017
osterman
osterman reviewed Aug 20, 2017
View reviewed changes
variables.tf
@@ -29,10 +29,12 @@ variable "datapipeline_config" {
}
}

variable "efs_ids" {
type = "list"
variable "efs_id" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deprecated variable

@osterman
Copy link
Member

  • rebase

osterman
osterman requested changes Aug 20, 2017
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deprecated efs_id variable

@const-bon
Copy link

Closing. Invalidated by #4 .

@const-bon const-bon closed this Sep 4, 2017
@s2504s s2504s deleted the efs_sg branch September 22, 2017 08:32
@s2504s s2504s restored the efs_sg branch September 22, 2017 08:32
@s2504s s2504s deleted the efs_sg branch September 22, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman requested changes

@const-bon const-bon Awaiting requested review from const-bon

Assignees

@s2504s s2504s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s2504s @osterman @const-bon