Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Role uses for-each instead of count #178

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Task Role uses for-each instead of count #178

merged 6 commits into from
Dec 1, 2022

Conversation

Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Dec 1, 2022 •
edited
Loading

what

  • task role uses for each

why

Note:

The outputs had to be changed to output a map as a single string, hence why they look complex, it's to keep backwards compatibility

@Benbentwo Benbentwo requested review from a team as code owners December 1, 2022 23:10
@Benbentwo Benbentwo requested review from r351574nc3 and srhopkins and removed request for a team December 1, 2022 23:10
@Benbentwo
Copy link
Member Author

/test all

@Benbentwo Benbentwo added patch A minor, backward compatible change bugfix Change that restores intended behavior labels Dec 1, 2022
@Benbentwo Benbentwo enabled auto-merge (squash) December 1, 2022 23:18
@Benbentwo Benbentwo merged commit 14008fc into master Dec 1, 2022
@Benbentwo Benbentwo deleted the bugfix/role-recreate branch December 1, 2022 23:20
draring pushed a commit to SevenPicoForks/terraform-aws-ecs-alb-service-task that referenced this pull request Feb 17, 2023
Merge branch 'master' of github.com:SevenPicoForks/terraform-aws-ecs-…
5f84484 
…alb-service-task

* 'master' of github.com:SevenPicoForks/terraform-aws-ecs-alb-service-task:
  fixes: Changing task_exec_policy_arns or task_policy_arns cause recreations cloudposse#167 (cloudposse#178)
  make `host_path` optional for fargate (cloudposse#176)
  Adding support for bind mount volume types (cloudposse#173)
  Update README.md and docs (cloudposse#171)
  Set bool inputs to type bool (cloudposse#170)
  Add ecs_service_enabled (cloudposse#169)
  BUG | Support Dynamic deployment_circuit_breaker for CODE_DEPLOY  (cloudposse#165)
  Added support to specify FSx Windows file server volumes (cloudposse#166)
  git-xargs programmatic commit (cloudposse#163)

# Conflicts:
#	main.tf
@Nuru Nuru mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing task_exec_policy_arns or task_policy_arns cause recreations
3 participants
@Benbentwo @milldr @cloudpossebot