make host_path optional for fargate
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
/test all |
nitrocode
reviewed
Nov 24, 2022
versions.tf
Outdated
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = ">= 0.13.0" | |||
| required_version = ">= 1.3.0" | |||
There was a problem hiding this comment.
Please don't increase the terraform this far. We have many users still using the old version.
I believe we also ran into an issue with optional inputs that @Nuru ran into.
Best of both worlds is to use a type = any imho to make all the inputs optional.
nitrocode
approved these changes
Nov 30, 2022
|
/test all |
draring
pushed a commit
to SevenPicoForks/terraform-aws-ecs-alb-service-task
that referenced
this pull request
Feb 17, 2023
…alb-service-task * 'master' of github.com:SevenPicoForks/terraform-aws-ecs-alb-service-task: fixes: Changing task_exec_policy_arns or task_policy_arns cause recreations cloudposse#167 (cloudposse#178) make `host_path` optional for fargate (cloudposse#176) Adding support for bind mount volume types (cloudposse#173) Update README.md and docs (cloudposse#171) Set bool inputs to type bool (cloudposse#170) Add ecs_service_enabled (cloudposse#169) BUG | Support Dynamic deployment_circuit_breaker for CODE_DEPLOY (cloudposse#165) Added support to specify FSx Windows file server volumes (cloudposse#166) git-xargs programmatic commit (cloudposse#163) # Conflicts: # main.tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
host_pathas optional in bind_mount_volumes for fargate which it cannot be specifiedwhy
references