Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for bind mount volume types #173

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Adding support for bind mount volume types #173

merged 3 commits into from
Sep 15, 2022

Conversation

bfox1793
Copy link
Contributor

@bfox1793 bfox1793 commented Sep 12, 2022 •
edited
Loading

what

  • Adding support for a basic bind_mount volume type for tasks

why

references

@bfox1793 bfox1793 requested review from a team as code owners September 12, 2022 19:22
@bfox1793 bfox1793 requested review from Gowiem and RothAndrew and removed request for a team September 12, 2022 19:22
@bfox1793
Copy link
Contributor Author

I tried running the make readme steps but got the below error. Not sure what I can do to get that generated here.

➜  terraform-aws-ecs-alb-service-task git:(add-support-bind-mount-volume-types) make readme
* Package gomplate already installed
* Package terraform-docs already installed
make: gomplate: No such file or directory
make: *** [readme/build] Error 1

@nitrocode
Copy link
Member

@bfox1793 please run make pr/auto-format locally 😄

@bfox1793
Copy link
Contributor Author

@bfox1793 please run make pr/auto-format locally 😄

Hmm, still running into some problems locally. Could the fact that I'm running on an arm machine be the root-cause?

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

** GitHub workflows update started **


** GitHub workflows updated **

main.tf
Using gomplate from /host/build-harness/vendor/gomplate
Using terraform-docs from /host/build-harness/vendor/terraform-docs
/bin/bash: line 1: /host/build-harness/vendor/terraform-docs: cannot execute binary file: Exec format error
make: *** [/host/build-harness/modules/docs/Makefile:21: docs/terraform.md] Error 126
make: *** [build-harness/runner] Error 2

@nitrocode
Copy link
Member

Hmmm. It's possible that it's failing due to arm. You could try to debug it by passing in make -n pr/auto-format and attempting to run the docker command directly.

You could also try to PR this in from a personal fork rather than a github org fork. That would probably let the cloudposse-bot commit the changes directly to the branch.

@Nuru
Copy link
Contributor

Nuru commented Sep 14, 2022

@bfox1793 wrote:

Hmm, still running into some problems locally. Could the fact that I'm running on an arm machine be the root-cause?

Perhaps, but it should not. Granted, we do not currently consider M1 supported, although it should mostly work via emulation. What is concerning here are these lines:

Using gomplate from /host/build-harness/vendor/gomplate
Using terraform-docs from /host/build-harness/vendor/terraform-docs

This means it is trying to run tools from the host file system, not the container. Our build harness will install the required tools, but we have not sorted out how to deal with the M1 vs Intel issue when doing so. In any case, that code is outdated, it should be using the tools in the container.

I suggest you try running:

make clean
make init
make pr/auto-format

If you still have problems, please paste the full output from make pr/auto-format.

@bfox1793
Copy link
Contributor Author

@bfox1793 wrote:

Hmm, still running into some problems locally. Could the fact that I'm running on an arm machine be the root-cause?

Perhaps, but it should not. Granted, we do not currently consider M1 supported, although it should mostly work via emulation. What is concerning here are these lines:

Using gomplate from /host/build-harness/vendor/gomplate
Using terraform-docs from /host/build-harness/vendor/terraform-docs

This means it is trying to run tools from the host file system, not the container. Our build harness will install the required tools, but we have not sorted out how to deal with the M1 vs Intel issue when doing so. In any case, that code is outdated, it should be using the tools in the container.

I suggest you try running:

make clean
make init
make pr/auto-format

If you still have problems, please paste the full output from make pr/auto-format.

Seems the make clean and running through the steps again worked! README is updated.

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 8cafc9c into cloudposse:master Sep 15, 2022
@nitrocode
Copy link
Member

Thank you @bfox1793 !

draring pushed a commit to SevenPicoForks/terraform-aws-ecs-alb-service-task that referenced this pull request Feb 17, 2023
Merge branch 'master' of github.com:SevenPicoForks/terraform-aws-ecs-…
5f84484 
…alb-service-task

* 'master' of github.com:SevenPicoForks/terraform-aws-ecs-alb-service-task:
  fixes: Changing task_exec_policy_arns or task_policy_arns cause recreations cloudposse#167 (cloudposse#178)
  make `host_path` optional for fargate (cloudposse#176)
  Adding support for bind mount volume types (cloudposse#173)
  Update README.md and docs (cloudposse#171)
  Set bool inputs to type bool (cloudposse#170)
  Add ecs_service_enabled (cloudposse#169)
  BUG | Support Dynamic deployment_circuit_breaker for CODE_DEPLOY  (cloudposse#165)
  Added support to specify FSx Windows file server volumes (cloudposse#166)
  git-xargs programmatic commit (cloudposse#163)

# Conflicts:
#	main.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for bind_mount style service volumes
3 participants
@bfox1793 @nitrocode @Nuru