Improved and added new UI components #14893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
requested changes
Sep 22, 2023
arkflpc
approved these changes
Sep 22, 2023
…f the templates search in ckeditor5-template.
… #resultsView instead of #filteredView upon focus().
…tent is empty in FF.
67b863b to
37d92de
Compare
…SearchResultsView a focus-friendly container. Made SearchInfoView focusable.
scofalik
requested changes
Sep 24, 2023
packages/ckeditor5-ui/src/highlightedtext/highlightedtextview.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/src/highlightedtext/highlightedtextview.ts
Outdated
Show resolved
Hide resolved
… implementing the focus() method.
Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
…ties view using the FocusCycler events.
Feature (ui): Implemented `FocusCycler#forwardCycle` and `#backwardCycle` events which are fired when last/first focusable item are focused and `FocusCycler` tries to focus next/previous item. These events can be overwritten to chain focus cyclers. Internal (ui): Made `SearchResultsView` a focus-friendly container. Made `SearchInfoView` focusable.
scofalik
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
ListItemGroupViewcomponent. Allowed groupingListViewitems.TextareaViewcomponent with the same base as theInputTextViewcomponent.SpinnerViewcomponent.SearchViewUI component. Created theAutocompleteViewcomponent. Introduced aHighlightedTextViewcomponent for better search results presentation. Made theButtonViewlabel logic open for extension.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.