Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing textarea and spinner component #14904

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Implementing textarea and spinner component #14904

merged 7 commits into from
Sep 8, 2023

Conversation

DawidKossowski
Copy link
Contributor

@DawidKossowski DawidKossowski commented Aug 31, 2023 •
edited
Loading

Suggested merge commit message (convention)

Feature (ui): Implementing the Textarea component with the same base as the Input component.
Feature (ui): Implementing the Spinner component.

@DawidKossowski DawidKossowski changed the title Implementing textarea component Implementing textarea and spinner component Sep 7, 2023
oleq
oleq requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@oleq oleq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also love how textarea view works out with LabeledFieldView (in a manual latest). Without that integration, the component will not make any sense, it must be labeled at some point.

Also, the CI is failing on this branch.

packages/ckeditor5-ui/src/textarea/textareaview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-ui/src/textarea/textareaview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-ui/src/spinner/spinnerview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-ui/theme/components/spinner/spinner.css Show resolved Hide resolved
@DawidKossowski DawidKossowski requested a review from oleq September 8, 2023 08:56
@oleq oleq merged commit 95c5282 into cf/5436 Sep 8, 2023
@oleq oleq deleted the cf/5436-textarea branch September 8, 2023 10:05
@oleq oleq mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scofalik scofalik Awaiting requested review from scofalik

@oleq oleq Awaiting requested review from oleq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DawidKossowski @oleq