Implemented FocusCycler#forwardCycle and #backwardCycle events

[oleq]

Suggested merge commit message (convention)

Feature (ui): Implemented FocusCycler#forwardCycle and #backwardCycle events.
Internal (ui): Made SearchResultsView a focus-friendly container. Made SearchInfoView focusable.

[scofalik]

What if I have a view that can be focused AND has focusable children? Shouldn't we let the view decide what it does upon being focused? EDIT: Actually, this is the definition of ViewWithFocusableChildren :D. So, that view is in theory focusable but it will never actually get the focus because it will always focus its child.

I am not sure if this logic should be inside FocusCycler but this is your domain so you decide.

[scofalik]

What is a "plain focusable view"? AFAICS, the implementation did not change. If this is to differentiate "focusable" from "focusable with focusable children", I wouldn't make a change. To me, it felt like maybe "plain focsuable view" is a focusable that is not a "focusable with focusable children". But that's not true. I might not get something, but at the first glance, the change and the new name is confusing.

[oleq]

@scofalik I went with your suggestions and moved the decision-making process down to implementers of the FocusableView interface (and the focus() method).

• focus() has an optional parameter that gives the view extra information about the direction of a traveling focus and it's up to the view to handle this information (or ignore it)
• I made the events cancellable, thus preventing unnecessary element focus in DOM if a custom logic takes over and focuses something else instead.
• I reverted the new interface for a view with focusable children. We don't need it (yet).

[oleq]

FYI: Recent changes to this PR (mainly: FocusCycler#focusNext() will no longer re-focus the same view over and over again if there's just one) revealed in unit tests that the focus management in the ColorInputView is totally accidental (but working from the UX standpoint). This is probably due to the fact that the component underwent refactoring this year and nobody realized that.

I addressed this issue and I took the liberty of using the new FC events in table forms to handle focus properly. Changes in 5f9bc87.