SearchKit - Make inline edit only available when applicable #23404
Conversation
|
(Standard links)
|
|
@colemanw error |
|
retest this please |
|
This PR triggered a seemingly-unrelated-yet-persistent test fail which took me down a rabbit-hole to refactor the entire APIv4 test suite: |
82ddd53 to
afc0907
Compare
|
@colemanw needs rebase |
f5f79a6 to
8970e37
Compare
|
@francescbassas thanks for your patience. Can you please review this PR once more so we can get it merged. While testing this, I found a pre-existing bug which I'll fix in a separate PR: editing a custom relationship field on a related contact search now "works" as in the field is only editable if applicable to that relationship type. However, the inline-edit results in the wrong relationship being updated! Please ignore that issue when testing this PR as it's pre-existing and will be addressed separately. |
8970e37 to
78b46e0
Compare
|
Wrong-record-edit bug fixed in #23496 |
|
@colemanw thanks for your work! Test site is down? http://core-23404-2mlpw.test-3.civicrm.org:8001 Is there any way to up it so that I can test it directly there? |
|
Not sure what happened to that site but @civicrm-builder retest this please. |
|
@francescbassas new test site is http://core-23404-2pdiy.test-3.civicrm.org:8001/ |
Fixes dev/core#3423 Ensures that custom fields for one entity sub-type (e.g. Individual) are not presented as editable for other sub-types (e.g. Organiztion).
78b46e0 to
489257b
Compare
|
Merging based on review from dev/core#3423 |
Fixes a regression caused by civicrm#23404
Fixes a regression caused by civicrm#23404
Fixes a regression caused by civicrm#23404
Overview
Fixes dev/core#3423 Make inline edit for custom fields only available when applicable
Before
Custom fields presented as editable for entity sub-types that they were not applicable to, e.g. if a set of custom fields only belongs to Activities of type Meeting, it would be editable for all activities in the SearchKit results table.
After
Correctly shown as editable only when applicable.