Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchKit - Fix editable when displaying an icon #24255

Merged
merged 1 commit into from
Aug 15, 2022
Merged

SearchKit - Fix editable when displaying an icon #24255

merged 1 commit into from
Aug 15, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes a regression caused by #23404

Before

  1. Add a search display with editable fields
  2. Add an icon to any field
  3. Editable no longer works

After

Fixed.

@civibot
Copy link

civibot bot commented Aug 14, 2022

(Standard links)

@civibot civibot bot added the master label Aug 14, 2022
@colemanw colemanw changed the base branch from master to 5.53 August 14, 2022 20:52
@civibot civibot bot added 5.53 and removed master labels Aug 14, 2022
@Levi-70
Copy link

Levi-70 commented Aug 15, 2022 •
edited
Loading

I verified that it is working in the test site 5.53beta1

@colemanw colemanw merged commit 7492c0f into civicrm:5.53 Aug 15, 2022
@colemanw colemanw deleted the fixSearchDisplayIcon branch August 15, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.53 has-test sig:regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @Levi-70