Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix in-place editing custom relationship fields #23496

Merged
merged 1 commit into from
May 21, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 19, 2022

Overview

Fixes bug in SearchKit in-place editing.

Before

In-place edit updates the wrong record for custom relationship fields in a related contact search.

After

Fixed. Test added.
Also added unit test coverage for #23496.

@civibot
Copy link

civibot bot commented May 19, 2022

(Standard links)

@civibot civibot bot added the master label May 19, 2022
@colemanw colemanw force-pushed the fixCustomGroupJoinable branch from 95d543e to 8c84888 Compare May 19, 2022 23:24
@colemanw colemanw marked this pull request as ready for review May 19, 2022 23:25
@colemanw
Copy link
Member Author

retest this please

@colemanw colemanw force-pushed the fixCustomGroupJoinable branch 2 times, most recently from cce5e49 to c1f5891 Compare May 20, 2022 13:04
…ed contacts

Before: In-place edit updates the wrong record for custom relationship fields
After: Fixed
@colemanw colemanw force-pushed the fixCustomGroupJoinable branch from c1f5891 to dff1b93 Compare May 20, 2022 21:32
@eileenmcnaughton
Copy link
Contributor

I confirmed the bug & fix in r-run.

@eileenmcnaughton eileenmcnaughton merged commit 85e7dfa into civicrm:master May 21, 2022
@eileenmcnaughton eileenmcnaughton deleted the fixCustomGroupJoinable branch May 21, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants