dev/core#2666 - Don't repeatedly log about crm-l10n.js during upgrade #20889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/2666
Before
For each individual task in the upgrade, there's an exception dump also logged for crm-l10n.js and it seems to be meaningless.
After
Just the upgrade steps logged.
Technical Details
I've put it against 5.40 since it seems to have come from #20121 which was in May. Before that, l10n.js wasn't generated by the asset builder so it didn't come up.
Comments
The inability to generate the file doesn't seem to affect upgrades on non-english sites. They still work as normal.
Note this may only be an issue for the UI upgrader. You may not see it if using
cv.An alternate is at #20890