Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2666 - Don't repeatedly log about crm-l10n.js during upgrade #20889

Closed
wants to merge 1 commit into from
Closed

dev/core#2666 - Don't repeatedly log about crm-l10n.js during upgrade #20889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Civi/Core/AssetBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,10 @@ public function build($name, $params, $force = FALSE) {
}
catch (UnknownAssetException $e) {
// unexpected error, log and continue
\Civi::log()->error('Unexpected error while rendering a file in the AssetBuilder: ' . $e->getMessage(), ['exception' => $e]);
// except during upgrade since this repeatedly logs about l10n for each individual upgrade task
if ($e->getMessage() !== 'Unrecognized asset name: crm-l10n.js' || !\CRM_Core_Config::isUpgradeMode()) {
\Civi::log()->error('Unexpected error while rendering a file in the AssetBuilder: ' . $e->getMessage(), ['exception' => $e]);
}
}
}
return $fileName;
Expand Down