Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2666 - (Alternate) Don't repeatedly log about crm-l10n.js during upgrade #20890

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Alternate to #20889

@civibot
Copy link

civibot bot commented Jul 17, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

this makes sense but want @totten @colemanw to comment

@colemanw
Copy link
Member

This makes sense but now I have to ask... if we're in upgrade mode, why add any core resources at all? Isn't upgrade mode only true for the ajax callback to run an upgrade step?

@seamuslee001
Copy link
Contributor

@colemanw it is also for the /upgrade urls which is the pre ajax and post ajax steps iirc and after and also its upgrade mode if set by drush/wp/cv iirc https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Config.php#L403

@colemanw
Copy link
Member

Ok then this is fine

@colemanw colemanw merged commit 07be8ef into civicrm:5.40 Jul 18, 2021
@demeritcowboy demeritcowboy deleted the ignore-log-upgrade-alt branch July 18, 2021 01:36
@demeritcowboy
Copy link
Contributor Author

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants